From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Joseph Nahmias <joe@nahmias.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: create database with template doesn't copy database ACL
Date: Tue, 16 Jun 2020 06:10:54 -0400
Message-ID: <20200616101054.GC31175@momjian.us> (raw)
In-Reply-To: <20200615141032.GC12121@momjian.us>
References: <159136749445.7029.12571169059565185790@wrigleys.postgresql.org>
<20200612212951.GB6813@momjian.us>
<20200614072613.GA21852@nahmias.net>
<20200615031102.GA12121@momjian.us>
<1092722.1592191496@sss.pgh.pa.us>
<20200615033934.GB12121@momjian.us>
<1095907.1592194495@sss.pgh.pa.us>
<20200615141032.GC12121@momjian.us>
On Mon, Jun 15, 2020 at 10:10:32AM -0400, Bruce Momjian wrote:
> On Mon, Jun 15, 2020 at 12:14:55AM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Well, I thought we copied everything except things tha can be specified
> > > as different in CREATE DATABASE, though I can see why we would not copy
> > > them. Should we document this or issue a notice about not copying
> > > non-default database attributes?
> >
> > We do not need a notice for behavior that (a) has stood for twenty years
> > or so, and (b) is considerably less broken than any alternative would be.
> > If you feel the docs need improvement, have at that.
>
> Well, I realize it has been this way for a long time, and that no one
> else has complained, but there should be a way for people to know what
> is being copied from the template and what is not. Do we have a clear
> description of what is copied and skipped?
We already mentioned that ALTER DATABASE settings are not copied, so the
attached patch adds a mention that GRANT-level permissions are not
copied either.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:template.diff (text/x-diff, 634B) downloaddiff --git a/doc/src/sgml/ref/create_database.sgml b/doc/src/sgml/ref/create_database.sgmlindex 504c1b0224..d116b321bc 100644--- a/doc/src/sgml/ref/create_database.sgml+++ b/doc/src/sgml/ref/create_database.sgml@@ -236,8 +236,8 @@ CREATE DATABASE <replaceable class="parameter">name</replaceable>
<para>
Database-level configuration parameters (set via <xref
- linkend="sql-alterdatabase"/>) are not copied from the template- database.+ linkend="sql-alterdatabase"/>) and database-level permissions (set via+ <xref linkend="sql-grant"/>) are not copied from the template database.
</para>
<para>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, joe@nahmias.net, pgsql-hackers@postgresql.org
Subject: Re: create database with template doesn't copy database ACL
In-Reply-To: <20200616101054.GC31175@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox