From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>
Cc: e.indrupskaya@postgrespro.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html
Date: Tue, 10 Nov 2020 18:06:36 -0500
Message-ID: <20201110230636.GA12947@momjian.us> (raw)
In-Reply-To: <93414.1604070598@sss.pgh.pa.us>
References: <160379568081.24752.14096853446375954245@wrigleys.postgresql.org>
<20201027165424.GO4951@momjian.us>
<CAH503wC7R-gvecEGTZNgv9v04u9Z579xjgTzBJ-JKDiqxvWL_g@mail.gmail.com>
<93414.1604070598@sss.pgh.pa.us>
On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote:
> Euler Taveira <euler.taveira@2ndquadrant.com> writes:
> > On Tue, 27 Oct 2020 at 13:54, Bruce Momjian <bruce@momjian.us> wrote:
> >> Uh, in my source tree that is a symlink to
> >> src/backend/catalog/pg_type_d.h, but that file is generated by
> >> src/backend/catalog/genbki.pl. Does that help you?
>
> > Shouldn't we replace "are defined in the file" with "are defined in the
> > generated file"? That's the only place that mentions *_d.h files. Perhaps
> > adding a link to BKI [1] should avoid further questions.
>
> It'd probably confuse users more, actually. This chapter is aimed at
> users of Postgres, not developers.
>
> >From a user's viewpoint, catalog/pg_type_d.h should look pretty much
> like any other installed header. We want to point them at that, not at
> pg_type.h, because the latter is painful to include in application code
> that doesn't want to buy into the Postgres programming environment
> altogether.
>
> Thinking about it from the perspective of someone dealing with an
> installation tree not a source tree, maybe the reference should
> be to "server/catalog/pg_type_d.h". That might help disabuse
> anyone who's expecting to find it at that path in the git tree.
I am confused what the "server/" prefix means in a path name.
We currently say:
The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>src/include/catalog/pg_type_d.h</filename> in the
source tree.
We could add "compiled":
The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>src/include/catalog/pg_type_d.h</filename> in the
source tree after it is compiled.
--------------------
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, euler.taveira@2ndquadrant.com, e.indrupskaya@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html
In-Reply-To: <20201110230636.GA12947@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox