pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: rir <rirans@comcast.net>
To: pgsql-docs@lists.postgresql.org
Subject: small patch
Date: Fri, 1 Oct 2021 21:06:06 -0400
Message-ID: <20211001163938.ifg4ayrsjwd7r6zr@localhost> (raw)

Minor changes to move.sgml and fetch.sgml.

The text 'or empty' is inconsistent by restating what the
synopsis notation has expressed.

The comments on sharing a language feature, while
likely helpful during review, seem verbose compared to
the non-commenting in other similar files.

Thanks again,
Rob

Attachments:

  [text/x-diff] empty.patch (1.7K, ../20211001163938.ifg4ayrsjwd7r6zr@localhost/2-empty.patch)
  download | inline diff:
:From a297377ad3b760f10e951cf67ad0cea704214f34 Mon Sep 17 00:00:00 2001
From: rir <rirans@comcast.net>
Date: Wed, 29 Sep 2021 19:06:01 -0400
Subject: [PATCH] "empty or" is unusual and redundant

---
 doc/src/sgml/ref/fetch.sgml | 4 ++--
 doc/src/sgml/ref/move.sgml  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/src/sgml/ref/fetch.sgml b/doc/src/sgml/ref/fetch.sgml
index ec843f5684..e76b6fc69d 100644
--- a/doc/src/sgml/ref/fetch.sgml
+++ b/doc/src/sgml/ref/fetch.sgml
@@ -25,11 +25,11 @@ PostgreSQL documentation
  </refnamediv>
 
  <refsynopsisdiv>
-<!-- Note the "direction" bit is also in ref/move.sgml -->
+
 <synopsis>
 FETCH [ <replaceable class="parameter">direction</replaceable> [ FROM | IN ] ] <replaceable class="parameter">cursor_name</replaceable>
 
-<phrase>where <replaceable class="parameter">direction</replaceable> can be empty or one of:</phrase>
+<phrase>where <replaceable class="parameter">direction</replaceable> can one of:</phrase>
 
     NEXT
     PRIOR
diff --git a/doc/src/sgml/ref/move.sgml b/doc/src/sgml/ref/move.sgml
index 4c7d1dca39..1ed06e4c9a 100644
--- a/doc/src/sgml/ref/move.sgml
+++ b/doc/src/sgml/ref/move.sgml
@@ -25,11 +25,11 @@ PostgreSQL documentation
  </refnamediv>
 
  <refsynopsisdiv>
-<!-- Note the "direction" bit is also in ref/fetch.sgml -->
+
 <synopsis>
 MOVE [ <replaceable class="parameter">direction</replaceable> [ FROM | IN ] ] <replaceable class="parameter">cursor_name</replaceable>
 
-<phrase>where <replaceable class="parameter">direction</replaceable> can be empty or one of:</phrase>
+<phrase>where <replaceable class="parameter">direction</replaceable> can one of:</phrase>
 
     NEXT
     PRIOR
-- 
2.20.1

view thread (16+ messages)  latest in thread

Message-ID: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
Permalink:  ../20211001163938.ifg4ayrsjwd7r6zr@localhost/
Also on:    postgresql.org/message-id/20211001163938.ifg4ayrsjwd7r6zr@localhost

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: rirans@comcast.net, pgsql-docs@lists.postgresql.org
  Subject: Re: small patch
  In-Reply-To: <20211001163938.ifg4ayrsjwd7r6zr@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox