public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: [email protected] <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pg_type_d.h location incorrect
Date: Sat, 29 May 2021 14:31:01 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS0PR01MB6113B7765814AC192CA8B420FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<OS0PR01MB6113637F7DBED4565902A460FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<[email protected]>
	<OS0PR01MB61131DD84072DC0DC5E3E003FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<[email protected]>
	<[email protected]>
	<OS0PR01MB61139DA2FBBBB092F5371265FB239@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<[email protected]>
	<OS0PR01MB6113B7765814AC192CA8B420FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>

"[email protected]" <[email protected]> writes:
> On Thursday, May 27, 2021 11:27 PM, Tom Lane <[email protected]> wrote
>> No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.

> Oh, never tried "patch -p1" command before but it worked. Thanks!!
> BTW, here is my previous operation to apply your patch(failed, which is strange IMO)

> $ git apply --3way improve-pgservice-docs.patch

Yeah, "git apply" is extremely picky.  I'm not sure we've ever figured out
all the reasons why it sometimes doesn't work.  Good old "patch" pretty
much always works though.

> Attached a patch to combine the above fix in your patch.
> Also fixed a typo in install-windows.sgml.
> Also fixed pgbuffercache.sgml as Michael commented at [1].

LGTM, pushed with one minor additional tweak.

			regards, tom lane

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_type_d.h location incorrect
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox