public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Julien Rouhaud <[email protected]>
Cc: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Subject: Re: Typo in perform.sgml?
Date: Sat, 07 Dec 2019 11:46:47 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOBaU_afRuoGf40O0YN_ncZ5L5pEXF8HaUXJ6A_S3XgOJWH5Dw@mail.gmail.com>
References: <[email protected]>
	<CAOBaU_afRuoGf40O0YN_ncZ5L5pEXF8HaUXJ6A_S3XgOJWH5Dw@mail.gmail.com>

Julien Rouhaud <[email protected]> writes:
> On Sat, Dec 7, 2019 at 12:05 PM Tatsuo Ishii <[email protected]> wrote:
>> Around line 904 of perform.sgml
>> "These node types have the ability to discard subnodes which they are
>> able to determine won't contain any records required by the query."
>> 
>> I was not able to parse this. Maybe "that they " is needed after
>> "determine"?

> Agreed.  Also, I'm not a native english speaker either, but the
> "which" sounds weird too.  How about:

> These node types have the ability to discard subnodes for which they
> are able to determine that won't contain any records required by the
> query.

Hm.  A grammar purist would say that the "which" should be "that",
because it's introducing a restrictive clause.  But I think the real
problem here is that "contain" is a crummy choice of verb: the notion
of a plan node "containing" records is what seems weird to me.
I think "produce" might work better.  Also, there's a lot of unnecessary
words here; I think we should be trying to make the sentence shorter
not longer.  How about something like

"These node types will discard subnodes when they detect that a
particular subnode won't produce any records required by the query."

Actually, that whole para could do with a rewrite; whoever wrote
it was obviously not familiar with Strunk & White's dictum
"Omit needless words".

			regards, tom lane

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Typo in perform.sgml?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox