From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: splarv@ya.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
Date: Thu, 15 Dec 2022 12:10:27 -0500
Message-ID: <3417417.1671124227@sss.pgh.pa.us> (raw)
In-Reply-To: <f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org>
<CAKFQuwbefvj25vYz-0KJ-62oCg8-BxAd3PButBZTJ-7PzUcGbQ@mail.gmail.com>
<f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> On 12/15/22 10:50 AM, David G. Johnston wrote:
>> I suggest changing it to:
>> SET configuration_parameter { TO | = } { value [, ...] | DEFAULT }
> +1 in general. I would also suggest we add an example in the Examples
> section to show what the output is when you add single-quotes.
I think the core problem here is that the syntax diagram and discussion
don't clearly discuss the behavior for list values. David's version of
the syntax diagram looks fine, but not sure about the text. There likely
needs to be some explicit acknowledgement of the fact that some GUCs
act differently than others (cf GUC_LIST_INPUT and GUC_LIST_QUOTE flags).
+1 for examples, for sure.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, jkatz@postgresql.org, david.g.johnston@gmail.com, splarv@ya.ru, pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
In-Reply-To: <3417417.1671124227@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox