pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedWho is a maintainer of GiST code ?
19+ messages / 6 participants
[nested] [flat]
* Who is a maintainer of GiST code ?
@ 2000-12-17 21:08 Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-17 21:08 UTC (permalink / raw)
To: Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Hi,
I checked 7.1 feature list and didn't find any mention about GiST
but there are changes in GiST code. Who is a maintainer of GiST code ?
We have several problems with GiSt and would like to communicate
with somebody who understand these code.
Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-17 22:53 Tom Lane <tgl@sss.pgh.pa.us>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2000-12-17 22:53 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov <oleg@sai.msu.su> writes:
> I checked 7.1 feature list and didn't find any mention about GiST
> but there are changes in GiST code. Who is a maintainer of GiST code ?
You are ;-). If you expect to find someone who understands GiST better
than you, you're probably out of luck.
I recall having made a number of changes that applied to all of the
index access methods, including GiST --- but I was just changing
similar code in all the methods. I don't claim to know anything
about GiST in particular.
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-18 04:23 Bruce Momjian <pgman@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 19+ messages in thread
From: Bruce Momjian @ 2000-12-18 04:23 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; PostgreSQL-development <pgsql-hackers@postgresql.org>
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > I checked 7.1 feature list and didn't find any mention about GiST
> > but there are changes in GiST code. Who is a maintainer of GiST code ?
>
> You are ;-). If you expect to find someone who understands GiST better
> than you, you're probably out of luck.
>
> I recall having made a number of changes that applied to all of the
> index access methods, including GiST --- but I was just changing
> similar code in all the methods. I don't claim to know anything
> about GiST in particular.
I know I met someone who said they invented Gist. Tom, was that at the
Database Summit? I can't think of that person's name now. I think
there are some papers at Berkeley or a web site that goes into it in
detail.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-18 04:30 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <pgman@candle.pha.pa.us>
1 sibling, 1 reply; 19+ messages in thread
From: Tom Lane @ 2000-12-18 04:30 UTC (permalink / raw)
To: Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I think
> there are some papers at Berkeley or a web site that goes into it in
> detail.
I imagine there's some GiST stuff at the Berkeley papers repository
http://s2k-ftp.CS.Berkeley.EDU:8000/postgres/papers/
but I'd be surprised if it's more than an overview...
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-18 20:49 Oleg Bartunov <oleg@sai.msu.su>
parent: Bruce Momjian <pgman@candle.pha.pa.us>
1 sibling, 1 reply; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-18 20:49 UTC (permalink / raw)
To: Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
OK, now I understand the situation. Another question:
Who is a maintainer of Rtree code ? We have a problem with
handling NULL values in GiST. Any thought how NULL values
are handle in Rtree.
regards,
Oleg
On Sun, 17 Dec 2000, Bruce Momjian wrote:
> Date: Sun, 17 Dec 2000 23:23:32 -0500 (EST)
> From: Bruce Momjian <pgman@candle.pha.pa.us>
> To: Tom Lane <tgl@sss.pgh.pa.us>
> Cc: Oleg Bartunov <oleg@sai.msu.su>,
> PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
>
> > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > I checked 7.1 feature list and didn't find any mention about GiST
> > > but there are changes in GiST code. Who is a maintainer of GiST code ?
> >
> > You are ;-). If you expect to find someone who understands GiST better
> > than you, you're probably out of luck.
> >
> > I recall having made a number of changes that applied to all of the
> > index access methods, including GiST --- but I was just changing
> > similar code in all the methods. I don't claim to know anything
> > about GiST in particular.
>
> I know I met someone who said they invented Gist. Tom, was that at the
> Database Summit? I can't think of that person's name now. I think
> there are some papers at Berkeley or a web site that goes into it in
> detail.
>
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman@candle.pha.pa.us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-18 21:10 Tom Lane <tgl@sss.pgh.pa.us>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2000-12-18 21:10 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov <oleg@sai.msu.su> writes:
> We have a problem with
> handling NULL values in GiST. Any thought how NULL values
> are handle in Rtree.
AFAIR, none of the index access methods except btree handle NULLs at
all --- they just ignore NULL values and don't store them in the index.
Feel free to improve on that ;-). The physical representation of index
tuples can handle NULLs, the problem is teaching the index logic where
they should go in the index.
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-19 00:04 Hannu Krosing <hannu@tm.ee>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 19+ messages in thread
From: Hannu Krosing @ 2000-12-19 00:04 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Tom Lane wrote:
>
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > We have a problem with
> > handling NULL values in GiST. Any thought how NULL values
> > are handle in Rtree.
>
> AFAIR, none of the index access methods except btree handle NULLs at
> all --- they just ignore NULL values and don't store them in the index.
> Feel free to improve on that ;-). The physical representation of index
> tuples can handle NULLs, the problem is teaching the index logic where
> they should go in the index.
>
> regards, tom lane
and I can't see why btree stores them (as it seems to do judging by the
index file size) - at least it does not use it for searching for "IS
NULL"
--8<--------8<--------8<--------8<--------8<--------8<--------8<--------8<------
hannu=# explain select * from nulltest where i is null;
NOTICE: QUERY PLAN:
Seq Scan on nulltest (cost=0.00..293.80 rows=5461 width=8)
EXPLAIN
hannu=# explain select * from nulltest where i =1;
NOTICE: QUERY PLAN:
Index Scan using nulltest_i_ndx on nulltest (cost=0.00..96.95 rows=164
width=8)
--8<--------8<--------8<--------8<--------8<--------8<--------8<--------8<------
nulltest is a 16k record table with numbers 1 to 16384 in field i
If it just ignored them we would have a nice way to fake partial indexes
-
just define a function that returns field value or null and then index
on that ;)
-----------
Hannu
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-19 00:25 Tom Lane <tgl@sss.pgh.pa.us>
parent: Hannu Krosing <hannu@tm.ee>
1 sibling, 0 replies; 19+ messages in thread
From: Tom Lane @ 2000-12-19 00:25 UTC (permalink / raw)
To: Hannu Krosing <hannu@tm.ee>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Hannu Krosing <hannu@tm.ee> writes:
> and I can't see why btree stores them (as it seems to do judging by the
> index file size) - at least it does not use it for searching for "IS
> NULL"
That's another thing that needs improvement ;-). Seems to me it should
be able to do that.
The reason why btree *has* to be able to deal with null entries is to
cope with multi-column indexes; you don't want it refusing to index a
row at all just because some of the columns are null. The others don't
currently handle multi-column indexes, so they're not really forced
to deal with that issue.
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-19 18:33 Christopher Masto <chris@netmonger.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 19+ messages in thread
From: Christopher Masto @ 2000-12-19 18:33 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; PostgreSQL-development <pgsql-hackers@postgresql.org>
On Sun, Dec 17, 2000 at 11:30:23PM -0500, Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I think
> > there are some papers at Berkeley or a web site that goes into it in
> > detail.
>
> I imagine there's some GiST stuff at the Berkeley papers repository
> http://s2k-ftp.CS.Berkeley.EDU:8000/postgres/papers/
> but I'd be surprised if it's more than an overview...
Well, there's this: http://gist.cs.berkeley.edu/
and this: http://gist.cs.berkeley.edu/pggist/
--
Christopher Masto Senior Network Monkey NetMonger Communications
chris@netmonger.net info@netmonger.net http://www.netmonger.net
Free yourself, free your machine, free the daemon -- http://www.freebsd.org/
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-19 19:25 Oleg Bartunov <oleg@sai.msu.su>
parent: Hannu Krosing <hannu@tm.ee>
1 sibling, 1 reply; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-19 19:25 UTC (permalink / raw)
To: Hannu Krosing <hannu@tm.ee>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
On Tue, 19 Dec 2000, Hannu Krosing wrote:
> Date: Tue, 19 Dec 2000 02:04:02 +0200
> From: Hannu Krosing <hannu@tm.ee>
> To: Tom Lane <tgl@sss.pgh.pa.us>
> Cc: Oleg Bartunov <oleg@sai.msu.su>,
> Bruce Momjian <pgman@candle.pha.pa.us>,
> PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
>
> Tom Lane wrote:
> >
> > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > We have a problem with
> > > handling NULL values in GiST. Any thought how NULL values
> > > are handle in Rtree.
> >
> > AFAIR, none of the index access methods except btree handle NULLs at
> > all --- they just ignore NULL values and don't store them in the index.
> > Feel free to improve on that ;-). The physical representation of index
> > tuples can handle NULLs, the problem is teaching the index logic where
> > they should go in the index.
> >
> > regards, tom lane
>
>
> and I can't see why btree stores them (as it seems to do judging by the
> index file size) - at least it does not use it for searching for "IS
> NULL"
and what does this error means ?
create table rtree_test ( r box );
copy rtree_test from stdin;
\N
\N
\N
\N
........ total 10,000 NULLS
\.
create index rtree_test_idx on rtree_test using rtree ( r );
--ERROR: floating point exception! The last floating point operation either exceeded legal ranges or was a divide by zero
seems rtree doesn't ignore NULL ?
Regards,
Oleg
>
> --8<--------8<--------8<--------8<--------8<--------8<--------8<--------8<------
>
> hannu=# explain select * from nulltest where i is null;
> NOTICE: QUERY PLAN:
>
> Seq Scan on nulltest (cost=0.00..293.80 rows=5461 width=8)
>
> EXPLAIN
> hannu=# explain select * from nulltest where i =1;
> NOTICE: QUERY PLAN:
>
> Index Scan using nulltest_i_ndx on nulltest (cost=0.00..96.95 rows=164
> width=8)
>
> --8<--------8<--------8<--------8<--------8<--------8<--------8<--------8<------
>
> nulltest is a 16k record table with numbers 1 to 16384 in field i
>
> If it just ignored them we would have a nice way to fake partial indexes
> -
> just define a function that returns field value or null and then index
> on that ;)
>
> -----------
> Hannu
>
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-19 20:26 Oleg Bartunov <oleg@sai.msu.su>
parent: Christopher Masto <chris@netmonger.net>
0 siblings, 0 replies; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-19 20:26 UTC (permalink / raw)
To: Christopher Masto <chris@netmonger.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
On Tue, 19 Dec 2000, Christopher Masto wrote:
> Date: Tue, 19 Dec 2000 13:33:58 -0500
> From: Christopher Masto <chris@netmonger.net>
> To: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <pgman@candle.pha.pa.us>
> Cc: Oleg Bartunov <oleg@sai.msu.su>,
> PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
>
> On Sun, Dec 17, 2000 at 11:30:23PM -0500, Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > I think
> > > there are some papers at Berkeley or a web site that goes into it in
> > > detail.
> >
> > I imagine there's some GiST stuff at the Berkeley papers repository
> > http://s2k-ftp.CS.Berkeley.EDU:8000/postgres/papers/
> > but I'd be surprised if it's more than an overview...
>
> Well, there's this: http://gist.cs.berkeley.edu/
> and this: http://gist.cs.berkeley.edu/pggist/
Thanks,
we do know this sites. We're working on implementation of
RD (Russian Doll) Tree using GiST interface. Current GiST sources
have some bugs, some of them we already fixed and currently we're a
working with handling of NULL values. We're getting broken index for
data with NULLs. btw, how many people use GiST ? It would be nice
to test our changes after we solve our problems.
Regards,
Oleg
> --
> Christopher Masto Senior Network Monkey NetMonger Communications
> chris@netmonger.net info@netmonger.net http://www.netmonger.net
>
> Free yourself, free your machine, free the daemon -- http://www.freebsd.org/
>
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-20 20:00 Tom Lane <tgl@sss.pgh.pa.us>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 2 replies; 19+ messages in thread
From: Tom Lane @ 2000-12-20 20:00 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Hannu Krosing <hannu@tm.ee>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov <oleg@sai.msu.su> writes:
> seems rtree doesn't ignore NULL ?
Hm, maybe not. There are explicit tests to ignore null inputs in hash
indexes (hash/hash.c), and I'd just sort of assumed that rtree and gist
do the same.
FWIW, your example doesn't seem to provoke an error in current sources;
but it does take quite a long time (far longer than building a btree
index on 10000 nulls). That makes me think that indexing nulls in rtree
might be a bad idea even if it works.
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-20 20:42 Oleg Bartunov <oleg@sai.msu.su>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 3 replies; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-20 20:42 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Hannu Krosing <hannu@tm.ee>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
We finished (cross fingers) our changes in GiST code for 7.0.3
and in next 2 days we plan to send patches for upcoming 7.1 release.
Isn't this too late ? What else we need to submit ?
We have int4array contribution package which added index support for
integer arrays and it's probably should come to contrib directory.
We got about 3 orders of magnitude speedup using RD-Tree.
Probably we need to add regression test for GiST.
We have following fixes for GiST (7.0.3):
1. indices now store on disk in compressed form - was decompressed which
causes broken index when using compression function
(now compression of indices is really works)
2. NULLs now don't broken index
3. added support for keys with variable length - was fixed-length
Patches and contribution package could be prepared in several days,
documentation with some benchmarks and blurbs require more time.
We plan to use these last changes to speedup our full-text-search
( killer application ) and write article to popularize GiST+Postgres.
Any thoughts ?
Regards,
Oleg
On Wed, 20 Dec 2000, Tom Lane wrote:
> Date: Wed, 20 Dec 2000 15:00:21 -0500
> From: Tom Lane <tgl@sss.pgh.pa.us>
> To: Oleg Bartunov <oleg@sai.msu.su>
> Cc: Hannu Krosing <hannu@tm.ee>, Bruce Momjian <pgman@candle.pha.pa.us>,
> PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
>
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > seems rtree doesn't ignore NULL ?
>
> Hm, maybe not. There are explicit tests to ignore null inputs in hash
> indexes (hash/hash.c), and I'd just sort of assumed that rtree and gist
> do the same.
>
> FWIW, your example doesn't seem to provoke an error in current sources;
> but it does take quite a long time (far longer than building a btree
> index on 10000 nulls). That makes me think that indexing nulls in rtree
> might be a bad idea even if it works.
>
> regards, tom lane
>
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-20 20:51 Tom Lane <tgl@sss.pgh.pa.us>
parent: Oleg Bartunov <oleg@sai.msu.su>
2 siblings, 0 replies; 19+ messages in thread
From: Tom Lane @ 2000-12-20 20:51 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Hannu Krosing <hannu@tm.ee>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov <oleg@sai.msu.su> writes:
> Probably we need to add regression test for GiST.
That would be nice, but let's not hold up the patches for it.
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-21 06:00 Thomas Lockhart <lockhart@alumni.caltech.edu>
parent: Oleg Bartunov <oleg@sai.msu.su>
2 siblings, 0 replies; 19+ messages in thread
From: Thomas Lockhart @ 2000-12-21 06:00 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Hannu Krosing <hannu@tm.ee>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
> We finished (cross fingers) our changes in GiST code for 7.0.3
> and in next 2 days we plan to send patches for upcoming 7.1 release.
> Isn't this too late ? What else we need to submit ?
Not too late, especially if it is fixing bugs. And even if not, anything
we can do to encourage active development and use of GiST is worth the
effort imho. I'll guess that unless we are talking about some extreme,
far-reaching changes in the backend others will agree.
> We have int4array contribution package which added index support for
> integer arrays and it's probably should come to contrib directory.
> We got about 3 orders of magnitude speedup using RD-Tree.
> Probably we need to add regression test for GiST.
> We have following fixes for GiST (7.0.3):
> 1. indices now store on disk in compressed form - was decompressed which
> causes broken index when using compression function
> (now compression of indices is really works)
> 2. NULLs now don't broken index
> 3. added support for keys with variable length - was fixed-length
> Patches and contribution package could be prepared in several days,
> documentation with some benchmarks and blurbs require more time.
> We plan to use these last changes to speedup our full-text-search
> ( killer application ) and write article to popularize GiST+Postgres.
> Any thoughts ?
Go go go !!! :)
- Thomas
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-21 09:05 Hannu Krosing <hannu@tm.ee>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 19+ messages in thread
From: Hannu Krosing @ 2000-12-21 09:05 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Tom Lane wrote:
>
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > seems rtree doesn't ignore NULL ?
>
> Hm, maybe not. There are explicit tests to ignore null inputs in hash
> indexes (hash/hash.c), and I'd just sort of assumed that rtree and gist
> do the same.
>
> FWIW, your example doesn't seem to provoke an error in current sources;
> but it does take quite a long time (far longer than building a btree
> index on 10000 nulls). That makes me think that indexing nulls in rtree
> might be a bad idea even if it works.
Or maybe just some optimisations done for large number of similar keys (
probabilistic page-splitting or some such ;) in btree are not done in
rtree ?
----------
Hannu
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-21 09:12 Hannu Krosing <hannu@tm.ee>
parent: Oleg Bartunov <oleg@sai.msu.su>
2 siblings, 1 reply; 19+ messages in thread
From: Hannu Krosing @ 2000-12-21 09:12 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov wrote:
>
> We finished (cross fingers) our changes in GiST code for 7.0.3
Are tha patches for 7.0.3 already available ?
> and in next 2 days we plan to send patches for upcoming 7.1 release.
> Isn't this too late ? What else we need to submit ?
> We have int4array contribution package which added index support for
> integer arrays
what exactly does it mean ?
can i now query for an int4array which contains number 42 or just
an int array that = '{1,2,3}' with index support ?
> and it's probably should come to contrib directory.
> We got about 3 orders of magnitude speedup using RD-Tree.
> Probably we need to add regression test for GiST.
Some samples will do fine for start ;)
> We have following fixes for GiST (7.0.3):
> 1. indices now store on disk in compressed form - was decompressed which
> causes broken index when using compression function
> (now compression of indices is really works)
> 2. NULLs now don't broken index
> 3. added support for keys with variable length - was fixed-length
>
> Patches and contribution package could be prepared in several days,
> documentation with some benchmarks and blurbs require more time.
> We plan to use these last changes to speedup our full-text-search
> ( killer application ) and write article to popularize GiST+Postgres.
> Any thoughts ?
Great!
-------
Hannu
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-21 11:45 Oleg Bartunov <oleg@sai.msu.su>
parent: Hannu Krosing <hannu@tm.ee>
0 siblings, 1 reply; 19+ messages in thread
From: Oleg Bartunov @ 2000-12-21 11:45 UTC (permalink / raw)
To: Hannu Krosing <hannu@tm.ee>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
On Thu, 21 Dec 2000, Hannu Krosing wrote:
> Date: Thu, 21 Dec 2000 11:12:41 +0200
> From: Hannu Krosing <hannu@tm.ee>
> To: Oleg Bartunov <oleg@sai.msu.su>
> Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <pgman@candle.pha.pa.us>,
> PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
>
> Oleg Bartunov wrote:
> >
> > We finished (cross fingers) our changes in GiST code for 7.0.3
>
> Are tha patches for 7.0.3 already available ?
>
yes, we could post it right now
> > and in next 2 days we plan to send patches for upcoming 7.1 release.
> > Isn't this too late ? What else we need to submit ?
> > We have int4array contribution package which added index support for
> > integer arrays
>
> what exactly does it mean ?
>
> can i now query for an int4array which contains number 42 or just
> an int array that = '{1,2,3}' with index support ?
>
yes, you need to apply out patch to GiST and functions for
RD-tree. I'll send you in private mail to conserve bandwidth.
It would be great if you test our code in your application.
Regards,
Oleg
> -------
> Hannu
>
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: Who is a maintainer of GiST code ?
@ 2000-12-21 20:05 Hannu Krosing <hannu@tm.ee>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 0 replies; 19+ messages in thread
From: Hannu Krosing @ 2000-12-21 20:05 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov wrote:
>
> On Thu, 21 Dec 2000, Hannu Krosing wrote:
>
> > Date: Thu, 21 Dec 2000 11:12:41 +0200
> > From: Hannu Krosing <hannu@tm.ee>
> > To: Oleg Bartunov <oleg@sai.msu.su>
> > Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <pgman@candle.pha.pa.us>,
> > PostgreSQL-development <pgsql-hackers@postgresql.org>
> > Subject: Re: [HACKERS] Who is a maintainer of GiST code ?
> >
> > Oleg Bartunov wrote:
> > >
> > > We finished (cross fingers) our changes in GiST code for 7.0.3
> >
> > Are tha patches for 7.0.3 already available ?
>
> yes, we could post it right now
Great!
> > > and in next 2 days we plan to send patches for upcoming 7.1 release.
> > > Isn't this too late ? What else we need to submit ?
> > > We have int4array contribution package which added index support for
> > > integer arrays
> >
> > what exactly does it mean ?
> >
> > can i now query for an int4array which contains number 42 or just
> > an int array that = '{1,2,3}' with index support ?
> >
>
> yes, you need to apply out patch to GiST and functions for
> RD-tree. I'll send you in private mail to conserve bandwidth.
> It would be great if you test our code in your application.
Thanks, I'm looking forwad to testing it.
---------------
Hannu
^ permalink raw reply [nested|flat] 19+ messages in thread
end of thread, other threads:[~2000-12-21 20:05 UTC | newest]
Thread overview: 19+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2000-12-17 21:08 Who is a maintainer of GiST code ? Oleg Bartunov <oleg@sai.msu.su>
2000-12-17 22:53 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-18 04:23 ` Bruce Momjian <pgman@candle.pha.pa.us>
2000-12-18 04:30 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-19 18:33 ` Christopher Masto <chris@netmonger.net>
2000-12-19 20:26 ` Oleg Bartunov <oleg@sai.msu.su>
2000-12-18 20:49 ` Oleg Bartunov <oleg@sai.msu.su>
2000-12-18 21:10 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-19 00:04 ` Hannu Krosing <hannu@tm.ee>
2000-12-19 00:25 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-19 19:25 ` Oleg Bartunov <oleg@sai.msu.su>
2000-12-20 20:00 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-20 20:42 ` Oleg Bartunov <oleg@sai.msu.su>
2000-12-20 20:51 ` Tom Lane <tgl@sss.pgh.pa.us>
2000-12-21 06:00 ` Thomas Lockhart <lockhart@alumni.caltech.edu>
2000-12-21 09:12 ` Hannu Krosing <hannu@tm.ee>
2000-12-21 11:45 ` Oleg Bartunov <oleg@sai.msu.su>
2000-12-21 20:05 ` Hannu Krosing <hannu@tm.ee>
2000-12-21 09:05 ` Hannu Krosing <hannu@tm.ee>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox