pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedCorrection for vacuum_multixact_failsafe_age
9+ messages / 4 participants
[nested] [flat]
* Correction for vacuum_multixact_failsafe_age
@ 2021-10-12 05:22 Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 9+ messages in thread
From: Pavel Luzanov @ 2021-10-12 05:22 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hello,
When trying to make a link to the new vacuum_multixact_failsafe_age parameter,
I found the wrong ID for this guc (missed word vacuum).
Please consider this patch for a fix.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
Attachments:
[text/x-patch] doc-vacuum-guc-multixact-failsafe-age.patch (689B, ../../c71a3cfc-a267-3d9f-1b44-fbd668d0ab10@postgrespro.ru/2-doc-vacuum-guc-multixact-failsafe-age.patch)
download | inline diff:
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 0a8e35c59f..0bcc6fd322 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -8799,7 +8799,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
</listitem>
</varlistentry>
- <varlistentry id="guc-multixact-failsafe-age" xreflabel="vacuum_multixact_failsafe_age">
+ <varlistentry id="guc-vacuum-multixact-failsafe-age" xreflabel="vacuum_multixact_failsafe_age">
<term><varname>vacuum_multixact_failsafe_age</varname> (<type>integer</type>)
<indexterm>
<primary><varname>vacuum_multixact_failsafe_age</varname> configuration parameter</primary>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
@ 2021-10-12 06:45 ` Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 1 reply; 9+ messages in thread
From: Laurenz Albe @ 2021-10-12 06:45 UTC (permalink / raw)
To: Pavel Luzanov <p.luzanov@postgrespro.ru>; pgsql-docs@lists.postgresql.org
On Tue, 2021-10-12 at 08:22 +0300, Pavel Luzanov wrote:
> When trying to make a link to the new vacuum_multixact_failsafe_age parameter,
> I found the wrong ID for this guc (missed word vacuum).
> Please consider this patch for a fix.
It is good to be consistent, but the name of the link is not essential, is it?
Changing it might break existing outside links.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
@ 2021-10-12 08:29 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 9+ messages in thread
From: Pavel Luzanov @ 2021-10-12 08:29 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; pgsql-docs@lists.postgresql.org
Hello,
>> When trying to make a link to the new vacuum_multixact_failsafe_age parameter,
>> I found the wrong ID for this guc (missed word vacuum).
>> Please consider this patch for a fix.
> It is good to be consistent, but the name of the link is not essential, is it?
> Changing it might break existing outside links.
Not essential, it's true. I haven't seen any rules in the documentation
on forming links for guc.
But how many external links could have been made since September 30?
And how many times in the future will people encounter inconsistency
in constructing a link to this parameter?
It seems to me that it's better to fix it.
But right now I need a link to this parameter for an article,
and I want to see if there's a chance to change the reference to the
familiar one
or use the current one.
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
@ 2021-10-12 17:46 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 9+ messages in thread
From: Alvaro Herrera @ 2021-10-12 17:46 UTC (permalink / raw)
To: Pavel Luzanov <p.luzanov@postgrespro.ru>; +Cc: Laurenz Albe <laurenz.albe@cybertec.at>; pgsql-docs@lists.postgresql.org, Peter G <pg@bowt.ie>
On 2021-Oct-12, Pavel Luzanov wrote:
> Hello,
>
> > > When trying to make a link to the new vacuum_multixact_failsafe_age parameter,
> > > I found the wrong ID for this guc (missed word vacuum).
> > > Please consider this patch for a fix.
> > It is good to be consistent, but the name of the link is not essential, is it?
> > Changing it might break existing outside links.
>
> Not essential, it's true. I haven't seen any rules in the documentation
> on forming links for guc.
>
> But how many external links could have been made since September 30?
> And how many times in the future will people encounter inconsistency
> in constructing a link to this parameter?
>
> It seems to me that it's better to fix it.
Yeah, this one is new as of commit 1e55e7d1755c; ISTM we should just fix it.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"La persona que no quería pecar / estaba obligada a sentarse
en duras y empinadas sillas / desprovistas, por cierto
de blandos atenuantes" (Patricio Vogel)
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-10-12 18:00 ` Peter Geoghegan <pg@bowt.ie>
2021-10-28 14:38 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 1 reply; 9+ messages in thread
From: Peter Geoghegan @ 2021-10-12 18:00 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Pavel Luzanov <p.luzanov@postgrespro.ru>; Laurenz Albe <laurenz.albe@cybertec.at>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Tue, Oct 12, 2021 at 10:46 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Yeah, this one is new as of commit 1e55e7d1755c; ISTM we should just fix it.
Agreed. Pushed Pavel's patch just now.
Thanks
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
@ 2021-10-28 14:38 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-28 20:58 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 9+ messages in thread
From: Pavel Luzanov @ 2021-10-28 14:38 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Laurenz Albe <laurenz.albe@cybertec.at>; Pg Docs <pgsql-docs@lists.postgresql.org>
Hi,
> Agreed. Pushed Pavel's patch just now.
Sorry, I didn't check it right away.
But it makes sense to backport to v14, where vacuum_multixact_failsafe_age was introduced.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
2021-10-28 14:38 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
@ 2021-10-28 20:58 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-28 21:24 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 9+ messages in thread
From: Alvaro Herrera @ 2021-10-28 20:58 UTC (permalink / raw)
To: Pavel Luzanov <p.luzanov@postgrespro.ru>; +Cc: Peter Geoghegan <pg@bowt.ie>; Laurenz Albe <laurenz.albe@cybertec.at>; Pg Docs <pgsql-docs@lists.postgresql.org>
On 2021-Oct-28, Pavel Luzanov wrote:
> Hi,
>
> > Agreed. Pushed Pavel's patch just now.
>
> Sorry, I didn't check it right away.
> But it makes sense to backport to v14, where vacuum_multixact_failsafe_age was introduced.
It is in 14.
Author: Peter Geoghegan <pg@bowt.ie>
Branch: master [00c61a74b] 2021-10-12 10:59:24 -0700
Branch: REL_14_STABLE [070c402b4] 2021-10-12 10:59:22 -0700
Doc: normalize vacuum_multixact_failsafe_age ID.
Author: Pavel Luzanov <p.luzanov@postgrespro.ru>
Discussion: https://postgr.es/m/c71a3cfc-a267-3d9f-1b44-fbd668d0ab10@postgrespro.ru
Backpatch: 14-, where the failsafe was introduced.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
2021-10-28 14:38 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-28 20:58 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-10-28 21:24 ` Peter Geoghegan <pg@bowt.ie>
2021-10-29 06:08 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 1 reply; 9+ messages in thread
From: Peter Geoghegan @ 2021-10-28 21:24 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Pavel Luzanov <p.luzanov@postgrespro.ru>; Laurenz Albe <laurenz.albe@cybertec.at>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Thu, Oct 28, 2021 at 1:58 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> It is in 14.
Right. It won't be reflected on the website until 14.1 is released, though.
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Correction for vacuum_multixact_failsafe_age
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Re: Correction for vacuum_multixact_failsafe_age Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
2021-10-28 14:38 ` Re: Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-28 20:58 ` Re: Correction for vacuum_multixact_failsafe_age Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-28 21:24 ` Re: Correction for vacuum_multixact_failsafe_age Peter Geoghegan <pg@bowt.ie>
@ 2021-10-29 06:08 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 0 replies; 9+ messages in thread
From: Pavel Luzanov @ 2021-10-29 06:08 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Laurenz Albe <laurenz.albe@cybertec.at>; Pg Docs <pgsql-docs@lists.postgresql.org>
Hi,
> It won't be reflected on the website until 14.1 is released, though.
Thank you! I had completely forgotten about that and looking for changes
on the website.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2021-10-29 06:08 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 05:22 Correction for vacuum_multixact_failsafe_age Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 06:45 ` Laurenz Albe <laurenz.albe@cybertec.at>
2021-10-12 08:29 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-12 17:46 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-12 18:00 ` Peter Geoghegan <pg@bowt.ie>
2021-10-28 14:38 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-10-28 20:58 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-10-28 21:24 ` Peter Geoghegan <pg@bowt.ie>
2021-10-29 06:08 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox