From: Mark Mielke <mark@mark.mielke.cc>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Date: Mon, 03 Sep 2007 10:47:43 -0400
Message-ID: <46DC1E8F.6040507@mark.mielke.cc> (raw)
In-Reply-To: <1692.1188826039@sss.pgh.pa.us>
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
<18259.1188773171@sss.pgh.pa.us>
<87y7foir7t.fsf@oxford.xeocode.com>
<19257.1188777110@sss.pgh.pa.us>
<87tzqci6tp.fsf@oxford.xeocode.com>
<20070903075609.GD21833@svr2.hagander.net>
<1692.1188826039@sss.pgh.pa.us>
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>
>> On Mon, Sep 03, 2007 at 07:47:14AM +0100, Gregory Stark wrote:
>>
>>> Actually I think in Windows \ : and . are problems (not allowed more
>>> than one dot in dos).
>> \ and : are problems.
>>
> Is : really a problem, given that the name in question will be appended
> to a known directory's path?
>
The file name shouldn't have a ':' in it. Accessing a path with multiple
':' in it to open a file for reading should just fail normally. So yes,
there should be no problem.
>> . is not a problem. We don't support 16-bit windows anyway, and multiple
>> dots works fine on any system we support.
>>
> I'm not convinced that . is issue-free. On most if not all versions of Unix,
> you are allowed to open a directory as a file and read the filenames it
> contains. While I don't say it'd be easy to manage that through
> tsearch, there's at least a potential for discovering the filenames
> present in . and .. --- how much do we care about that?
>
No more than discovering the file names in any other directory without
using '.' or '..'? If it matters, check to ensure it is a regular file
before opening it?
Cheers,
mark
--
Mark Mielke <mark@mielke.cc>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: mark@mark.mielke.cc, tgl@sss.pgh.pa.us, magnus@hagander.net, stark@enterprisedb.com, oleg@sai.msu.su, pavel.stehule@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: tsearch filenames unlikes special symbols and numbers
In-Reply-To: <46DC1E8F.6040507@mark.mielke.cc>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox