public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Thom Brown <[email protected]>
Cc: [email protected]
Subject: Re: Confusing link in streaming replication section
Date: Thu, 25 Feb 2010 12:41:35 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Fujii Masao wrote:
> On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas
> <[email protected]> wrote:
>> Yeah, it's not very clear as it is.
>>
>> How about this:
>>
>> --- a/doc/src/sgml/recovery-config.sgml
>> +++ b/doc/src/sgml/recovery-config.sgml
>> @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f"
>> "%p"'
>>         <listitem>
>>          <para>
>>           Specifies a connection string to be used for the standby server
>> -          to connect with the primary. This string is in the same format as
>> +          to connect with the primary. This string is in the format
>> +          accepted by the libpq <function>PQconnectdb</function> function,
>>           described in <xref linkend="libpq-connect">. If any option is
>>           unspecified in this string, then the corresponding environment
>>           variable (see <xref linkend="libpq-envars">) is checked. If the
> 
> The following description in the document about PQconnectdb() doesn't fit
> primary_conninfo because of restriction of readRecoveryCommandFile().
> 
> ---------------
> To write an empty value, or a value containing spaces,
> surround it with single quotes, e.g., keyword = 'a value'. Single quotes
> and backslashes within the value must be escaped with a backslash,
> i.e., \' and \\.
> ---------------

Hmm, so how does one escape quotes in recovery.conf? That would be valid
information, if readRecoveryCommandFile() didn't choke on quotes.

At some point we'll have to make the recovery.conf parsing smarter, if
only for consistency with postgresql.conf, or merge them completely...

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Confusing link in streaming replication section
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox