From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Fix incorrect UUID index entry in function documentation
Date: Tue, 24 Jun 2025 14:37:07 +0900
Message-ID: <4cf5c255-6801-4ca0-ae40-f1a418cb34c3@oss.nttdata.com> (raw)
In-Reply-To: <2b4a16fc-cec0-4e15-b8b1-c1a22401005b@oss.nttdata.com>
References: <f33e0493-5773-4296-87c5-7ce459054cfe@oss.nttdata.com>
<CAD21AoCm=a=rohh6ULRqNahX4m_Q5USPv9SHTnoBEHEPjZxBsw@mail.gmail.com>
<274659ec-3eed-40fb-85d3-bc35014c57a1@oss.nttdata.com>
<5508B177-2609-442F-9FB5-B24CF9C51556@yesql.se>
<2b4a16fc-cec0-4e15-b8b1-c1a22401005b@oss.nttdata.com>
On 2025/06/24 0:46, Fujii Masao wrote:
>
>
> On 2025/06/23 23:52, Daniel Gustafsson wrote:
>>> On 23 Jun 2025, at 16:40, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>>> So barring any objections, I will commit the patch.
>>
>> +1, LGTM.
>
> Thanks for the review!
>
>> There is one more occurrence though, the relnotes seem to need the
>> same treatment as they talk about UUID functions and not the UUID datatype:
>>
>> diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
>> index 662c7d8890f..fba01d3ca44 100644
>> --- a/doc/src/sgml/release-18.sgml
>> +++ b/doc/src/sgml/release-18.sgml
>> @@ -2498,7 +2498,7 @@ Author: Masahiko Sawada <msawada@postgresql.org>
>>
>> <listitem>
>> <para>
>> - Add <link linkend="datatype-uuid"><type>UUID</type></link>
>> + Add <link linkend="functions-uuid"><type>UUID</type></link>
>> version 7 generation function <link
>> linkend="func_uuid_gen_table"><function>uuidv7()</function></link>
>> (Andrey Borodin)
>
> That "UUID" here seems to refer to the general concept, so I don't think
> it needs to link specifically to the UUID functions page. Since the UUID
> data type page already provides a basic explanation, it makes sense for
> the link to point there. Also, since "uuidv7()" and "uuidv4()" there
> already link to the UUID functions page, that seems sufficient to me.
> Thought?
I've committed the proposed patch first. If we later agree to change
this part as well, we can commit that separately.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, daniel@yesql.se, sawada.mshk@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Fix incorrect UUID index entry in function documentation
In-Reply-To: <4cf5c255-6801-4ca0-ae40-f1a418cb34c3@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox