pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira <euler@timbira.com.br>
Cc: vodevsh@gmail.com
Cc: pgsql-docs@postgresql.org
Subject: Re: misleading ALTER TABLE SET STORAGE
Date: Thu, 10 Nov 2016 10:04:06 -0500
Message-ID: <5019.1478790246@sss.pgh.pa.us> (raw)
In-Reply-To: <271e1212-5159-f939-ed9c-10573a538f69@timbira.com.br>
References: <20161108142739.27613.11510@wrigleys.postgresql.org>
	<271e1212-5159-f939-ed9c-10573a538f69@timbira.com.br>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>

Euler Taveira <euler@timbira.com.br> writes:
> On 08-11-2016 11:27, vodevsh@gmail.com wrote:
>> Was reading
>> https://www.postgresql.org/docs/current/static/storage-toast.html and the
>> bit with &quot;...table column can be altered with ALTER TABLE SET STORAGE...&quot;
>> appeared misleading to me.

> AFAICS ALTER TABLE SET STORAGE means ALTER TABLE ... ALTER COLUMN SET
> STORAGE. There is no ALTER TABLE SET STORAGE per table. It seems you are
> confusing with ALTER TABLE SET (storage_parameter = value, ...).

> Perhaps, we should use the complete command (ALTER TABLE tablename ALTER
> COLUMN colname SET STORAGE storagetype) or link ALTER TABLE to avoid
> confusion.

Our usual practice is to insert ellipses where there are omissions,
so this probably ought to read "ALTER TABLE ... SET STORAGE".  We could
go with "ALTER TABLE ... ALTER COLUMN ... SET STORAGE", but that's
more verbose and not any more correct.

A link might not be a bad thing either, but it's sort of an independent
question.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



view thread (3+ messages)

Message-ID: <5019.1478790246@sss.pgh.pa.us>
Permalink:  ../5019.1478790246@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5019.1478790246@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, euler@timbira.com.br, vodevsh@gmail.com
  Subject: Re: misleading ALTER TABLE SET STORAGE
  In-Reply-To: <5019.1478790246@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox