pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: eggyknap <eggyknap@gmail.com>
To: pgsql-docs@postgresql.org
Subject: Minor quibble with description of WINDOW clause
Date: Tue, 4 Jun 2013 21:05:57 -0600
Message-ID: <51aeaae5.a5ac420a.05d9.4850@mx.google.com> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>

The way the WINDOW clause docs are currently worded, it's clear from the
grammar tree that such clauses come toward the end of the query. But this
phrase made me wonder, incorrectly, whether they were supposed to come before
calls to window functions, somehow:

"...where window_name is a name that can be referenced from subsequent window
definitions or OVER clauses"

See http://www.postgresql.org/docs/9.3/static/sql-select.html#SQL-WINDOW for
the full context.

I'd have preferred to see "...from OVER clauses or subsequent window
definitions", which the attached simple patch does. And if I'm the only one
that likes the idea of such a change, I'll gladly go away quietly. :)

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

Attachments:

window.doc.patch (text/x-diff, 851B) download
diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml
index 213ea09..68309ba 100644
--- a/doc/src/sgml/ref/select.sgml
+++ b/doc/src/sgml/ref/select.sgml
@@ -654,8 +654,8 @@ HAVING <replaceable class="parameter">condition</replaceable>
 WINDOW <replaceable class="parameter">window_name</replaceable> AS ( <replaceable class="parameter">window_definition</replaceable> ) [, ...]
 </synopsis>
     where <replaceable class="parameter">window_name</replaceable> is
-    a name that can be referenced from subsequent window definitions or
-    <literal>OVER</> clauses, and
+    a name that can be referenced from <literal>OVER</> clauses or
+    subsequent window definitions, and
     <replaceable class="parameter">window_definition</replaceable> is
 <synopsis>
 [ <replaceable class="parameter">existing_window_name</replaceable> ]

  signature.asc (application/pgp-signature, 835B) download

view thread (2+ messages)  latest in thread

Message-ID: <51aeaae5.a5ac420a.05d9.4850@mx.google.com>
Permalink:  ../51aeaae5.a5ac420a.05d9.4850@mx.google.com/
Also on:    postgresql.org/message-id/51aeaae5.a5ac420a.05d9.4850@mx.google.com

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: eggyknap@gmail.com
  Subject: Re: Minor quibble with description of WINDOW clause
  In-Reply-To: <51aeaae5.a5ac420a.05d9.4850@mx.google.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox