pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Minor quibble with description of WINDOW clause 2+ messages / 2 participants [nested] [flat]
* Minor quibble with description of WINDOW clause @ 2013-06-05 03:05 eggyknap <eggyknap@gmail.com> 2013-06-07 04:11 ` Re: Minor quibble with description of WINDOW clause Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 2+ messages in thread From: eggyknap @ 2013-06-05 03:05 UTC (permalink / raw) To: pgsql-docs The way the WINDOW clause docs are currently worded, it's clear from the grammar tree that such clauses come toward the end of the query. But this phrase made me wonder, incorrectly, whether they were supposed to come before calls to window functions, somehow: "...where window_name is a name that can be referenced from subsequent window definitions or OVER clauses" See http://www.postgresql.org/docs/9.3/static/sql-select.html#SQL-WINDOW for the full context. I'd have preferred to see "...from OVER clauses or subsequent window definitions", which the attached simple patch does. And if I'm the only one that likes the idea of such a change, I'll gladly go away quietly. :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com Attachments:signature.asc (application/pgp-signature, 835B) download ^ permalink raw reply [nested|flat] 2+ messages in threadwindow.doc.patch (text/x-diff, 851B) download
diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml index 213ea09..68309ba 100644 --- a/doc/src/sgml/ref/select.sgml +++ b/doc/src/sgml/ref/select.sgml @@ -654,8 +654,8 @@ HAVING <replaceable class="parameter">condition</replaceable> WINDOW <replaceable class="parameter">window_name</replaceable> AS ( <replaceable class="parameter">window_definition</replaceable> ) [, ...] </synopsis> where <replaceable class="parameter">window_name</replaceable> is - a name that can be referenced from subsequent window definitions or - <literal>OVER</> clauses, and + a name that can be referenced from <literal>OVER</> clauses or + subsequent window definitions, and <replaceable class="parameter">window_definition</replaceable> is <synopsis> [ <replaceable class="parameter">existing_window_name</replaceable> ]
* Re: Minor quibble with description of WINDOW clause 2013-06-05 03:05 Minor quibble with description of WINDOW clause eggyknap <eggyknap@gmail.com> @ 2013-06-07 04:11 ` Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2013-06-07 04:11 UTC (permalink / raw) To: eggyknap <eggyknap@gmail.com>; +Cc: pgsql-docs eggyknap <eggyknap@gmail.com> writes: > The way the WINDOW clause docs are currently worded, it's clear from the > grammar tree that such clauses come toward the end of the query. But this > phrase made me wonder, incorrectly, whether they were supposed to come before > calls to window functions, somehow: > "...where window_name is a name that can be referenced from subsequent window > definitions or OVER clauses" > See http://www.postgresql.org/docs/9.3/static/sql-select.html#SQL-WINDOW for > the full context. > I'd have preferred to see "...from OVER clauses or subsequent window > definitions", which the attached simple patch does. And if I'm the only one > that likes the idea of such a change, I'll gladly go away quietly. :) I think you're right. Applied and back-patched. regards, tom lane -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2013-06-07 04:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2013-06-05 03:05 Minor quibble with description of WINDOW clause eggyknap <eggyknap@gmail.com> 2013-06-07 04:11 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox