public inbox for [email protected]  

help / color / mirror / Atom feed

From: Charles Clavadetscher <[email protected]>
To: Stephen Frost <[email protected]>
Cc: [email protected]
Subject: Re: [DOCS] Missing COMMENT ON POLICY
Date: Sun, 13 Sep 2015 16:25:53 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>

Stephen

On 13/09/2015 15:26, Charles Clavadetscher wrote:
> Hello Stephen
>
> On 13/09/2015 14:49, Stephen Frost wrote:
>> Charles,
>>
>> Just FYI, on these lists, we'd prefer it if you wouldn't top-post.
>>
>> * Charles Clavadetscher ([email protected]) wrote:
>>> Yes, of course. I will take care of that and send a new patch.
>> Thanks!
>>
>>> Who will then git push it?
>> I'd be happy to take care of it, though any of the committers may pick
>> it up, of course.  If there's a concern about the patch being missed or
>> forgotten then it can be added to the commitfest system (here:
>> http://commitfest.postgresql.org).  I don't believe there's a risk of
>> that here, but you're welcome to add it if you'd like, of course.
>>
>>> Thank you for your feedback.
>> Thank you for working on this!
>>
>> Stephen
> In the attachement the new patch. I was not able to create one with both
> commits so I also added the first one.
> I think that documentation should be as complete as possible, but if you
> say that there is no risk in missing the update, then I don't see a need
> to add a line in the commitfest.
>
> Thank you also for the hint on top-posting. I was not aware of that.
> Have a good Sunday.
> Charles

I noticed that the position of the parameter "policy_name" in the 
description list of parameters was not at the (alphabetically) correct 
position. I changed that and the result is attached.

I think/hope that is now all correct.

Thank you and bye
Charles


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Attachments:

  [application/softgrid-patch] correct_order_position_of_parameter.patch (975B, 2-correct_order_position_of_parameter.patch)
  download | inline diff:
commit 51ef905d3d81c18634c7bc6d40f02e602cc5af3c
Author: Charles Clavadetscher <[email protected]>
Date:   Sun Sep 13 15:50:33 2015 +0200

    Move of parameter description line to correct position.

diff --git a/doc/src/sgml/ref/comment.sgml b/doc/src/sgml/ref/comment.sgml
index 197f78a..3321d4b 100644
--- a/doc/src/sgml/ref/comment.sgml
+++ b/doc/src/sgml/ref/comment.sgml
@@ -114,8 +114,8 @@ COMMENT ON
     <term><replaceable class="parameter">constraint_name</replaceable></term>
     <term><replaceable class="parameter">function_name</replaceable></term>
     <term><replaceable class="parameter">operator_name</replaceable></term>
-    <term><replaceable class="parameter">rule_name</replaceable></term>
     <term><replaceable class="parameter">policy_name</replaceable></term>
+    <term><replaceable class="parameter">rule_name</replaceable></term>
     <term><replaceable class="parameter">trigger_name</replaceable></term>
     <listitem>
      <para>

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [DOCS] Missing COMMENT ON POLICY
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox