From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: descriptions of pg_stat_user_functions and pg_stat_slru
Date: Wed, 20 May 2020 15:53:23 -0400
Message-ID: <5996.1590004403@sss.pgh.pa.us> (raw)
In-Reply-To: <bd73f8fe-7a9f-d903-b84f-8410ba3e1d5f@oss.nttdata.com>
References: <6f8a482c-b3fa-4ed9-21c3-6d222a2cb87d@oss.nttdata.com>
<23668.1589940341@sss.pgh.pa.us>
<f31875d6-2300-87af-1479-c9d9abc013be@oss.nttdata.com>
<19926.1589981558@sss.pgh.pa.us>
<bd73f8fe-7a9f-d903-b84f-8410ba3e1d5f@oss.nttdata.com>
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2020/05/20 22:32, Tom Lane wrote:
>> OK by me --- that, too, would be more like the existing catalogs
>> chapter.
> Yeah, so I'd like to propose the attached patch.
Hmmm ... I'm not exactly convinced about sticking xreflabels onto
the <sect2>s as you've done here. Presumably that would make <xref>s
render like "pg_stat_slru" not "Section 27.2.3", which I think is
not consistent with our practice elsewhere. I'd be inclined to
leave the id attributes on the <table>s, and add xreflabels there
if we want them.
I see that catalogs.sgml doesn't really match either of those approaches,
though. Not sure if we want to change it. It looks like people have
tended to use <link> to substitute text for xref's to the catalog
sections, so maybe it would be better to add xreflabels there too
and simplify the references.
Other than that markup quibble, this looks fine to me.
> - 6644 | LWLock | ProcArrayLock
> + 6644 | LWLock | ProcArray
> I found "ProcArrayLock" is still used in monitoring.sgml though
> it was renamed to ProcArray. So the patch also includes the above change.
Ooops, my oversight.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, pgsql-docs@lists.postgresql.org
Subject: Re: descriptions of pg_stat_user_functions and pg_stat_slru
In-Reply-To: <5996.1590004403@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox