pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Curt Kolovson <ckolovson@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html
Date: Mon, 17 Jul 2023 18:52:34 -0700
Message-ID: <672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com> (raw)
In-Reply-To: <4114624.1689643322@sss.pgh.pa.us>
References: <4114624.1689643322@sss.pgh.pa.us>

Tom is correct. It appears that nobody tested this example, which by the way seems unnecessarily complicated. 

Sent from my iPhone

> On Jul 17, 2023, at 6:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> "David G. Johnston" <david.g.johnston@gmail.com> writes:
>>> On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson <ckolovson@gmail.com> wrote:
>>> The actual results (shown below) are different than shown on this doc
>>> page.
> 
>> SPI_exec sees "INSERT 0 2" as the command tag from the SQL command you
>> passed and so 2 is the output of the execq function call.
>> No INFO messages appear because you did not include a returning clause.
>> The 1 you passed to the call is immaterial if the query you supply doesn't
>> produce a result set.
> 
> I think his point is that this example does not behave as the
> documentation claims.  Which it does not, according to my
> tests here.  I find this a bit disturbing --- did we intentionally
> change the behavior of SPI_exec somewhere along the line?
> 
>            regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com>
Permalink:  ../672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com/
Also on:    postgresql.org/message-id/672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: ckolovson@gmail.com, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, pgsql-docs@lists.postgresql.org
  Subject: Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html
  In-Reply-To: <672A5662-FB6C-454B-AD82-BDC30474E47C@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox