From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: daniel@yesql.se
Cc: a.lakhin@postgrespro.ru
Cc: pgsql-docs@postgresql.org
Subject: Re: Missing comma?
Date: Wed, 13 May 2020 17:17:43 +0300
Message-ID: <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru> (raw)
In-Reply-To: <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
References: <ad1a0badc32658b1bbb07aa312346a1d@postgrespro.ru>
<5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
Thanks!
P.S. Looking at the final sentence:
"Columns used to form “replica identity” for rows: d = default (primary
key, if any), n = nothing, f = all columns, i = index with
indisreplident set, or default"
in my opinion it's a little unclear what "or default" means at the end,
because the comma is used to separate enumeration elements ("d = default
<...>, n = nothing, f = all columns, i = index <...>") and inside the
element description ("i = index with indisreplident set, or default").
Therefore here is an additional patch from me to clarify this place,
thanks to Alexander Lakhin for help.
On 2020-05-13 16:23, Daniel Gustafsson wrote:
>> On 13 May 2020, at 12:20, Marina Polyakova
>> <m.polyakova@postgrespro.ru> wrote:
>
>> https://www.postgresql.org/docs/current/catalog-pg-class.html says
>> "Columns used to form “replica identity” for rows: d = default
>> (primary key, if any), n = nothing, f = all columns i = index with
>> indisreplident set, or default". Am I wrong, or is there a missing
>> comma (or other punctuation mark) before "i = index"?..
>
> I agree with this, there should be a comma between "f = all columns"
> and "i =
> index with.." per the below:
>
> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index ce33df9e58..cbd76e1bf5 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -1935,7 +1935,7 @@ SCRAM-SHA-256$<replaceable><iteration
> count></replaceable>:<replaceable>&l
> Columns used to form <quote>replica identity</quote> for rows:
> <literal>d</literal> = default (primary key, if any),
> <literal>n</literal> = nothing,
> - <literal>f</literal> = all columns
> + <literal>f</literal> = all columns,
> <literal>i</literal> = index with
> <structfield>indisreplident</structfield> set, or default
> </entry>
> </row>
>
> cheers ./daniel
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:diff_relreplident_index_desc.patch (text/x-diff, 708B) downloaddiff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgmlindex 02ddebae99d98110a8dd290dd4cb0c980adf7984..034a08f80ea4269f131e7e1383ba482fd76d9344 100644--- a/doc/src/sgml/catalogs.sgml+++ b/doc/src/sgml/catalogs.sgml@@ -1936,7 +1936,7 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
<literal>d</literal> = default (primary key, if any),
<literal>n</literal> = nothing,
<literal>f</literal> = all columns,
- <literal>i</literal> = index with <structfield>indisreplident</structfield> set, or default+ <literal>i</literal> = index with <structfield>indisreplident</structfield> set (if any)
</entry>
</row>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: m.polyakova@postgrespro.ru, daniel@yesql.se, a.lakhin@postgrespro.ru
Subject: Re: Missing comma?
In-Reply-To: <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox