From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: marcmaiwald@googlemail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Lower or Upper case for F.33. pg_trgm
Date: Tue, 16 Aug 2022 23:28:13 +0200
Message-ID: <7657EDEE-5EE2-4AAB-BA95-47B4F71653E1@yesql.se> (raw)
In-Reply-To: <1119558.1660658030@sss.pgh.pa.us>
References: <166064504415.652.12724576876807446945@wrigleys.postgresql.org>
<65FB8525-EB15-4A22-B204-51385A088D64@yesql.se>
<3856dba5-81c8-8221-90e6-5307679f9be7@xs4all.nl>
<5B31E9AC-9F6B-47BB-85DB-188507CF6297@yesql.se>
<4be605ae-7fbb-c47c-9c7f-f8965ff0ea9e@xs4all.nl>
<1119558.1660658030@sss.pgh.pa.us>
> On 16 Aug 2022, at 15:53, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Erik Rijkers <er@xs4all.nl> writes:
>> (bluntly stating 'similarity comparisons are case-insensitive' -
>> although I'm not really sure..)
>
> Perhaps like "similarity comparisons are case-insensitive in a
> standard build of pg_trgm", if you want to nod to the existence
> of a compile option without going into detail.
Looking at this I'm leaning towards paring down the diff posted upthread with
pretty much this, I think that will provide value while avoid causing
confusion.
As a related side note, there are four instances of "case insensitive{ly}" in
the docs with all other instances using "case-insensitive{ly}". I'm inclined
to fix those four to use a dash while at it to be consistent across all pages.
--
Daniel Gustafsson https://vmware.com/Attachments:
[application/octet-stream] pg_trgm_case.diff (680B, ../7657EDEE-5EE2-4AAB-BA95-47B4F71653E1@yesql.se/2-pg_trgm_case.diff)
download | inline diff:diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/pgtrgm.sgmlindex 7e29282255..fefe30afb7 100644--- a/doc/src/sgml/pgtrgm.sgml+++ b/doc/src/sgml/pgtrgm.sgml@@ -416,6 +416,8 @@
the above-described similarity operators, and additionally support
trigram-based index searches for <literal>LIKE</literal>, <literal>ILIKE</literal>,
<literal>~</literal>, <literal>~*</literal> and <literal>=</literal> queries.
+ The similarity comparisons are case-insensitive in a default build of+ <filename>pg_trgm</filename>.
Inequality operators are not supported.
Note that those indexes may not be as efficient as regular B-tree indexes
for equality operator.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, er@xs4all.nl, marcmaiwald@googlemail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Lower or Upper case for F.33. pg_trgm
In-Reply-To: <7657EDEE-5EE2-4AAB-BA95-47B4F71653E1@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox