From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Date: Mon, 03 Sep 2007 10:09:03 -0400
Message-ID: <8195.1188828543@sss.pgh.pa.us> (raw)
In-Reply-To: <87zm03zwqs.fsf@oxford.xeocode.com>
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
<18259.1188773171@sss.pgh.pa.us>
<87y7foir7t.fsf@oxford.xeocode.com>
<19257.1188777110@sss.pgh.pa.us>
<87tzqci6tp.fsf@oxford.xeocode.com>
<20070903075609.GD21833@svr2.hagander.net>
<1692.1188826039@sss.pgh.pa.us>
<87zm03zwqs.fsf@oxford.xeocode.com>
Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>> I'm not convinced that . is issue-free. On most if not all versions of Unix,
>> you are allowed to open a directory as a file and read the filenames it
>> contains. While I don't say it'd be easy to manage that through
>> tsearch, there's at least a potential for discovering the filenames
>> present in . and .. --- how much do we care about that?
> Actually I don't think that's true any more, most file systems on most Unixen
> do not allow it. However it appears it's still the case for Solaris so it's
> still a good point.
Actually, now that I've woken up a bit more, it is not a problem as
long as the tsearch code always appends some kind of file extension
to what the user gives, such as ".dict". It'll be impossible to name
"." or ".." with that addition.
Also, Magnus says that Windows throws an error for ":" in the filename,
which means we needn't.
So the bottom line seems to be that rejecting directory separators
is sufficient to prevent any unwanted file accesses.
It might still be a good idea to restrict the names to be SQL
identifiers (ie, alphanumerics and underscores) for future-proofing,
but it wasn't clear whether anyone but me thought that was a good
argument. I'm willing to make it just be no-dir-separators.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, stark@enterprisedb.com, magnus@hagander.net, oleg@sai.msu.su, pavel.stehule@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: tsearch filenames unlikes special symbols and numbers
In-Reply-To: <8195.1188828543@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox