agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Clarify old WAL files cannot be removed until they are summarized
Date: Fri, 13 Dec 2024 00:08:06 +0900
Message-ID: <87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com> (raw)
In-Reply-To: <Z1jaaLi2vq-Wpk9y@paquier.xyz>
References: <fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com>
<Z1jaaLi2vq-Wpk9y@paquier.xyz>
On 2024/12/11 9:18, Michael Paquier wrote:
> On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:
>> The documentation in wal.sgml explains that old WAL files cannot be
>> removed or recycled until they are archived (when WAL archiving is used)
>> or replicated (when using replication slots). However, it did not
>> mention that, similarly, old WAL files are also kept until they are summarized
>> if WAL summarization is enabled. Attached patch adds that clarification to
>> the documentation. Thought?
>>
>> @@ -643,6 +643,8 @@
>> until the situation is resolved. A slow or failed standby server that
>> uses a replication slot will have the same effect (see
>> <xref linkend="streaming-replication-slots"/>).
>> + Similarly, if WAL summarization is enabled, old segments are kept
>> + until they are summarized.
>> </para>
>
> Sounds like a good idea to me. I'd suggest to add a link to
> runtime-config-wal-summarization as it is the first reference to WAL
> summarization in this file.
Yes, that sounds like a good idea. I've updated the patch accordingly.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From b0d6ceb6799889e3d9269948342a249c67c71341 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Thu, 12 Dec 2024 23:46:23 +0900
Subject: [PATCH v2] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
Back-patch to v17 where WAL summarization was added.
Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com
---
doc/src/sgml/wal.sgml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..b908720ade 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,9 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if <link linkend="runtime-config-wal-summarization">
+ WAL summarization</link> is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.47.0
Attachments:
[text/plain] v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch (1.4K, ../87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com/2-v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch)
download | inline diff:
From b0d6ceb6799889e3d9269948342a249c67c71341 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Thu, 12 Dec 2024 23:46:23 +0900
Subject: [PATCH v2] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
Back-patch to v17 where WAL summarization was added.
Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com
---
doc/src/sgml/wal.sgml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..b908720ade 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,9 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if <link linkend="runtime-config-wal-summarization">
+ WAL summarization</link> is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.47.0
view thread (5+ messages) latest in thread
Message-ID: <87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com>
Permalink: ../87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com/
Also on: postgresql.org/message-id/87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, michael@paquier.xyz, pgsql-docs@lists.postgresql.org
Subject: Re: Clarify old WAL files cannot be removed until they are summarized
In-Reply-To: <87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox