From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@postgresql.org
Subject: Re: TLS docs fixes for <programlisting>
Date: Thu, 14 May 2020 09:38:09 +0200
Message-ID: <928D3FE2-7DB9-4AA9-9AAD-5CD1F09448EF@yesql.se> (raw)
In-Reply-To: <20200514021713.GB166343@paquier.xyz>
References: <401F9024-20EA-4239-83C4-6B7AD35F94BD@yesql.se>
<20200514021713.GB166343@paquier.xyz>
> On 14 May 2020, at 04:17, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, May 13, 2020 at 11:07:44PM +0200, Daniel Gustafsson wrote:
>> While working with TLS I noticed that the password callback definition had an
>> extra newline in the programlisting in the docs. Since the <programlisting>
>> has been indented with the textblock, the newline comes from whitespace being
>> significant. The attached 0001 fixes by instead anchoring <programlisting> on
>> column zero like how most of the docs do it. Grepping around I found one more
>> instance of the same pattern which is also included.
>
> Indeed, I can see the difference. In what I spotted after applying
> 0001, you are patching the one in libpq.sgml as of 0002 but in a
> different, correct, way, and I have spotted three more inconsistencies
> within doc/src/sgml/datatype.sgml in the zone for timestamps.
Right, I omitted them to avoid churn since they are using <programlisting>
correctly, just in a different way from the rest of the docs. I'll leave the
call whether they should be included for consistency sake to you.
> With everything I found on top of your stuff, I finish with the
> attached. Does it look fine to you?
+1, thanks for picking it up!
cheers ./daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: daniel@yesql.se, michael@paquier.xyz
Subject: Re: TLS docs fixes for <programlisting>
In-Reply-To: <928D3FE2-7DB9-4AA9-9AAD-5CD1F09448EF@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox