From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@postgresql.org, Gavin Sherry <swm@linuxworld.com.au>
Cc: Michael Glaesemann <grzm@seespotcode.net>
Cc: Joe Conway <mail@joeconway.com>
Cc: pgsql-patches@postgresql.org
Cc: pgsql-docs@postgresql.org
Subject: Re: [PATCHES] Values list-of-targetlists patch for comments (was Re:
Date: Thu, 03 Aug 2006 22:50:17 -0400
Message-ID: <969.1154659817@sss.pgh.pa.us> (raw)
In-Reply-To: <Pine.LNX.4.58.0608041040550.16622@linuxworld.com.au>
References: <44B69778.5050104@dunslane.net>
<44B7ADFC.90205@dunslane.net>
<44BC0432.3040509@joeconway.com>
<44BC661F.80609@joeconway.com>
<44CFFD2D.8040906@joeconway.com>
<Pine.LNX.4.58.0608031523090.4590@linuxworld.com.au>
<18685.1154617090@sss.pgh.pa.us>
<429A0065-78C7-48C9-B2DC-E898988F93E6@seespotcode.net>
<Pine.LNX.4.58.0608041040550.16622@linuxworld.com.au>
Gavin Sherry <swm@linuxworld.com.au> writes:
> On Fri, 4 Aug 2006, Michael Glaesemann wrote:
>> On Aug 3, 2006, at 23:58 , Tom Lane wrote:
>>> Should we give VALUES its own reference page? That doesn't quite
>>> seem helpful either.
>>
>> I think we should go for a separate reference page, as VALUES appears
>> to be expanding quite a bit.
> ... with update? I associate it very closely with INSERT. After all,
> INSERT is the only statement where we've had VALUES as part of the
> grammar.
True, but I think that's just a historical artifact. If you look at the
SQL spec, INSERT ... VALUES and INSERT ... SELECT are not distinct
constructs: they fall out of the fact that VALUES and SELECT are allowed
interchangeably.
<insert statement> ::=
INSERT INTO <table name>
<insert columns and source>
<insert columns and source> ::=
[ <left paren> <insert column list> <right paren> ]
<query expression>
| DEFAULT VALUES
<insert column list> ::= <column name list>
and when you trace down <query expression> you find the SELECT
and VALUES options entering at exactly the same place ...
I'd like to see us refactor the docs as necessary to reflect that idea.
Peter is right that this needs some discussion in syntax.sgml as well as
in the reference pages --- but I'm still not very clear on how the
presentation should go.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, swm@linuxworld.com.au, grzm@seespotcode.net, mail@joeconway.com, pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Values list-of-targetlists patch for comments (was Re:
In-Reply-To: <969.1154659817@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox