public inbox for [email protected]
help / color / mirror / Atom feedFrom: Erik Wienhold <[email protected]>
To: David Rowley <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected]
Subject: Re: Use uppercase keywords in foreign key tutorial
Date: Wed, 5 Nov 2025 19:09:28 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
References: <aQE29YG5pY4Cl8ym@nathan>
<[email protected]>
<[email protected]>
<CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
<[email protected]>
<CAApHDvoqh_K2KTocwWYrGw5vLubnPnTzd1SvYTTonQ=vUXP7Ug@mail.gmail.com>
<[email protected]>
<CAApHDvraaZLdTm4XTLkgGhUwecpmNm1dOJMcEToak-Bh5742hQ@mail.gmail.com>
<[email protected]>
<CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
On 2025-11-04 03:09 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 13:04, Erik Wienhold <[email protected]> wrote:
> >
> > On 2025-11-03 23:37 +0100, David Rowley wrote:
> > > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > > change.
> >
> > I think it's worth to have that consistency. If the patch is too broad
> > I can of course limit it to the listings with inconsistent keyword
> > casing which is more less patch v2 plus some changes from v3 and later.
> >
> > Or just fix the keywords for now to get that out of the way and deal
> > with the spacing in a separate patch/thread.
>
> I think just the keyword upper casing is a good idea for now. I'm
> starting to lose hope that there's enough merit and consistency to the
> proposed whitespace changes. Maybe there's a subset of it that does
> make sense to do.
Done in the attached v6. But I kept the few whitespace changes on lines
where I change keywords to uppercase. It's mostly a single space after
commas in column and parameter lists which I think also enhances
readability.
--
Erik Wienhold
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Use uppercase keywords in foreign key tutorial
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox