public inbox for [email protected]  
help / color / mirror / Atom feed
From: Oleg Bartunov <[email protected]>
To: Thomas Munro <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: [email protected]
Subject: Re: bloom documentation patch
Date: Wed, 17 Oct 2018 23:45:30 +0300
Message-ID: <CAF4Au4zptWXPCc=mxUz7SScMgyTi9cW=FpWdz50QM3gEs_fi_w@mail.gmail.com> (raw)
In-Reply-To: <CAEepm=3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy+=5A@mail.gmail.com>
References: <CAF4Au4wPQQ7EHVSnzcLjsbY3oLSzVk6UemZLD1Sbmwysy3R61g@mail.gmail.com>
	<CAEepm=3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy+=5A@mail.gmail.com>

On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro
<[email protected]> wrote:
>
> On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <[email protected]> wrote:
> > Please, consider attached patch, which improves contrib/bloom documentation.
>
> Hello Oleg, I have no comment on the technical details but here is
> some proof-reading of the English:
>
> +      Length of each signature (index entry) in bits, it is rounded
> up to the nearest
> +      multiple of 16. The default is <literal>80</literal> bits and maximum is
>
> s/, it is/.  It is/
> s/and maximum/and the maximum/
>
> +       Bloom AM doesn't supports <literal>unique</literal> indexes.
>
> s/supports/support/
>
> +       Bloom AM doesn't supports <literal>NULL</literal> values.
>
> s/supports/support/
>

Thanks, Thomas, new patch attached.

> --
> Thomas Munro
> http://www.enterprisedb.com
>


-- 
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


Attachments:

  [application/octet-stream] bloom.sgml.patch (623B, 2-bloom.sgml.patch)
  download | inline diff:
--- bloom.sgml.old	2018-10-15 11:56:17.000000000 +0300
+++ bloom.sgml	2018-10-17 23:40:30.000000000 +0300
@@ -51,9 +51,9 @@
     <term><literal>length</literal></term>
     <listitem>
      <para>
-      Length of each signature (index entry) in bits, it is rounded up to the
+      Length of each signature (index entry) in bits. It is rounded up to the
       nearest multiple of <literal>16</literal>. The default is
-      <literal>80</literal> bits and maximum is <literal>4096</literal>.
+      <literal>80</literal> bits and the maximum is <literal>4096</literal>.
      </para>
     </listitem>
    </varlistentry>


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: bloom documentation patch
  In-Reply-To: <CAF4Au4zptWXPCc=mxUz7SScMgyTi9cW=FpWdz50QM3gEs_fi_w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox