public inbox for [email protected]  
help / color / mirror / Atom feed
From: Alexander Korotkov <[email protected]>
To: Oleg Bartunov <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: [email protected]
Subject: Re: bloom documentation patch
Date: Mon, 22 Oct 2018 00:33:42 +0300
Message-ID: <CAPpHfduS2L8KLvpgO4c8Ou-s3Sq2QO9Uf1PqgYcFc2qapb+TGw@mail.gmail.com> (raw)
In-Reply-To: <CAF4Au4zptWXPCc=mxUz7SScMgyTi9cW=FpWdz50QM3gEs_fi_w@mail.gmail.com>
References: <CAF4Au4wPQQ7EHVSnzcLjsbY3oLSzVk6UemZLD1Sbmwysy3R61g@mail.gmail.com>
	<CAEepm=3sijpGr8tXdyz-7EJJZfhQHABPKEQ29gpnb7-XSy+=5A@mail.gmail.com>
	<CAF4Au4zptWXPCc=mxUz7SScMgyTi9cW=FpWdz50QM3gEs_fi_w@mail.gmail.com>

On Wed, Oct 17, 2018 at 11:45 PM Oleg Bartunov <[email protected]> wrote:
> On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro
> <[email protected]> wrote:
> >
> > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <[email protected]> wrote:
> > > Please, consider attached patch, which improves contrib/bloom documentation.
> >
> > Hello Oleg, I have no comment on the technical details but here is
> > some proof-reading of the English:
> >
> > +      Length of each signature (index entry) in bits, it is rounded
> > up to the nearest
> > +      multiple of 16. The default is <literal>80</literal> bits and maximum is
> >
> > s/, it is/.  It is/
> > s/and maximum/and the maximum/

Thank you for these corrections.  They are pushed.

> > +       Bloom AM doesn't supports <literal>unique</literal> indexes.
> >
> > s/supports/support/
> >
> > +       Bloom AM doesn't supports <literal>NULL</literal> values.
> >
> > s/supports/support/

These two were already fixed in the version I've pushed before.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: bloom documentation patch
  In-Reply-To: <CAPpHfduS2L8KLvpgO4c8Ou-s3Sq2QO9Uf1PqgYcFc2qapb+TGw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox