public inbox for [email protected]  
help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Erik Rijkers <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: [email protected]
Subject: Re: Fwd: [DOCS] pgbench doc typos
Date: Mon, 1 Feb 2016 22:08:09 +0900
Message-ID: <CAHGQGwHWjhquD1fsXTnYTKCDnN+wCuFO5_irfN0UTq9fexLKJQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>

On Wed, Jan 27, 2016 at 8:32 PM, Erik Rijkers <[email protected]> wrote:
> On 2016-01-27 11:06, Erik Rijkers wrote:
>>
>> Two trivial changes to  doc/src/sgml/ref/pgbench.sgml

-   Here is example outputs:
+   Here is example output:

"Here are example outputs" is better?
In 9.4 document, that description was used for the example outputs
of per-transaction logging.

> I did not understand this sentence:
>
>    "Notice that while the plain (unaggregated) log file contains index
>    of the custom script files, the aggregated log does not."
>
> "contains index"?  what does that mean?
>
> Not understanding, I have not changed it. I think it could be made more
> clear.

What about the following?

--------------------
When multiple custom script files are specified with -f option,
while the plain (unaggregated) log file contains <lateral>file_no</> field
which identifies which script file is used, the aggregated log does not.
Therefore if you need per script data, <option>--aggregate-interval</> option
should not be specified and you need to aggregate the data on your own
from the plain log file.
--------------------

BTW, I found another problem in pgbench.sgml. skipped_transactions is
documented as the last field of the plain log, but the format of the log
doesn't include that as follows.

    client_id transaction_no time file_no time_epoch time_us [schedule_lag]

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fwd: [DOCS] pgbench doc typos
  In-Reply-To: <CAHGQGwHWjhquD1fsXTnYTKCDnN+wCuFO5_irfN0UTq9fexLKJQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox