public inbox for [email protected]
help / color / mirror / Atom feedpgtesttiming.sgml, FreeBSD command output
4+ messages / 3 participants
[nested] [flat]
* pgtesttiming.sgml, FreeBSD command output
@ 2012-07-06 20:21 Josh Kupershmidt <[email protected]>
2012-07-06 20:33 ` Re: pgtesttiming.sgml, FreeBSD command output Peter Eisentraut <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Josh Kupershmidt @ 2012-07-06 20:21 UTC (permalink / raw)
To: pgsql-docs
I noticed this little snippet claiming to be output on FreeBSD in
pgtesttiming.sgml:
<screen>
dmesg | grep "Timecounter"
sysctl kern.timecounter.hardware=TSC
</screen>
First, grep is case-sensitive by default, so that line of output
shouldn't have matched at all, right? Second, if I actually try the
above command on a FreeBSD 9 VM I have, I get (copying by hand, since
I can't seem to copy-and-paste out of this VM without X, please excuse
any typos):
Timecounter "ACPI-fast" frequency 3579545 Hz quality 900
Timecounter "i8254" frequency 1193182 Hz quality 0
Timecounters tick every 10.000 msec
Timecounter "TSC" frequency 2531787134 Hz quality 800
Anyway, if the original "sysctl ..." output is valid for a FreeBSD
machine, maybe only the grep command needs to be fixed (i.e. to "grep
-i ...") ?
Josh
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgtesttiming.sgml, FreeBSD command output
2012-07-06 20:21 pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
@ 2012-07-06 20:33 ` Peter Eisentraut <[email protected]>
2012-07-06 21:09 ` Re: pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Peter Eisentraut @ 2012-07-06 20:33 UTC (permalink / raw)
To: Josh Kupershmidt <[email protected]>; +Cc: pgsql-docs
On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
> I noticed this little snippet claiming to be output on FreeBSD in
> pgtesttiming.sgml:
>
> <screen>
> dmesg | grep "Timecounter"
> sysctl kern.timecounter.hardware=TSC
> </screen>
>
> First, grep is case-sensitive by default, so that line of output
> shouldn't have matched at all, right?
I don't think this was meant to say that the second line is the output
of the first. I read this as two separate commands. But I agree this
part is a bit unclear.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgtesttiming.sgml, FreeBSD command output
2012-07-06 20:21 pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
2012-07-06 20:33 ` Re: pgtesttiming.sgml, FreeBSD command output Peter Eisentraut <[email protected]>
@ 2012-07-06 21:09 ` Josh Kupershmidt <[email protected]>
2012-08-30 22:38 ` Re: pgtesttiming.sgml, FreeBSD command output Bruce Momjian <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Josh Kupershmidt @ 2012-07-06 21:09 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: pgsql-docs
On Fri, Jul 6, 2012 at 1:33 PM, Peter Eisentraut <[email protected]> wrote:
> On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
>> <screen>
>> dmesg | grep "Timecounter"
>> sysctl kern.timecounter.hardware=TSC
>> </screen>
>>
>> First, grep is case-sensitive by default, so that line of output
>> shouldn't have matched at all, right?
>
> I don't think this was meant to say that the second line is the output
> of the first. I read this as two separate commands. But I agree this
> part is a bit unclear.
Oh, I see now. The <screen> sections above and below that one were
including output, and I was just expecting the same here.
One way to fix would be to include shell prompts and outputs for both
commands (patch Option 1, attached). Or, if we don't want to bother
including output, as the section does now, maybe we could at least
include the shell prompts and mention that output is excluded (patch
Option 2).
I've also attached an unrelated typofix I noticed for the same page.
Josh
Attachments:
[application/octet-stream] pgtesttiming_typofix.diff (854B, 2-pgtesttiming_typofix.diff)
download | inline diff:
diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index f74d63e..fcd8996
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 277,283 ****
</para>
<para>
! Timers used on older PC hardware including the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
--- 277,283 ----
</para>
<para>
! Timers used on older PC hardware include the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
[application/octet-stream] pgtesttiming_output_Option2.diff (845B, 3-pgtesttiming_output_Option2.diff)
download | inline diff:
diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index f74d63e..0554316
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 180,190 ****
<para>
FreeBSD also allows changing the time source on the fly, and it logs
! information about the timer selected during boot:
<screen>
! dmesg | grep "Timecounter"
! sysctl kern.timecounter.hardware=TSC
</screen>
</para>
--- 180,191 ----
<para>
FreeBSD also allows changing the time source on the fly, and it logs
! information about the timer selected during boot (outputs of these two
! commands are omitted for brevity):
<screen>
! # dmesg | grep "Timecounter"
! # sysctl kern.timecounter.hardware=TSC
</screen>
</para>
[application/octet-stream] pgtesttiming_output_Option1.diff (860B, 4-pgtesttiming_output_Option1.diff)
download | inline diff:
diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index f74d63e..13baf67
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 183,190 ****
information about the timer selected during boot:
<screen>
! dmesg | grep "Timecounter"
! sysctl kern.timecounter.hardware=TSC
</screen>
</para>
--- 183,195 ----
information about the timer selected during boot:
<screen>
! # dmesg | grep "Timecounter"
! Timecounter "ACPI-fast" frequency 3579545 Hz quality 900
! Timecounter "i8254" frequency 1193182 Hz quality 0
! Timecounters tick every 10.000 msec
! Timecounter "TSC" frequency 2531787134 Hz quality 800
! # sysctl kern.timecounter.hardware=TSC
! kern.timecounter.hardware: ACPI-fast -> TSC
</screen>
</para>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgtesttiming.sgml, FreeBSD command output
2012-07-06 20:21 pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
2012-07-06 20:33 ` Re: pgtesttiming.sgml, FreeBSD command output Peter Eisentraut <[email protected]>
2012-07-06 21:09 ` Re: pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
@ 2012-08-30 22:38 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Momjian @ 2012-08-30 22:38 UTC (permalink / raw)
To: Josh Kupershmidt <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; pgsql-docs
Patch attached and applied for PG 9.3.
---------------------------------------------------------------------------
On Fri, Jul 6, 2012 at 02:09:00PM -0700, Josh Kupershmidt wrote:
> On Fri, Jul 6, 2012 at 1:33 PM, Peter Eisentraut <[email protected]> wrote:
> > On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
>
> >> <screen>
> >> dmesg | grep "Timecounter"
> >> sysctl kern.timecounter.hardware=TSC
> >> </screen>
> >>
> >> First, grep is case-sensitive by default, so that line of output
> >> shouldn't have matched at all, right?
> >
> > I don't think this was meant to say that the second line is the output
> > of the first. I read this as two separate commands. But I agree this
> > part is a bit unclear.
>
> Oh, I see now. The <screen> sections above and below that one were
> including output, and I was just expecting the same here.
>
> One way to fix would be to include shell prompts and outputs for both
> commands (patch Option 1, attached). Or, if we don't want to bother
> including output, as the section does now, maybe we could at least
> include the shell prompts and mention that output is excluded (patch
> Option 2).
>
> I've also attached an unrelated typofix I noticed for the same page.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachments:
[text/x-diff] timer.diff (1.5K, 2-timer.diff)
download | inline diff:
diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index 45ee80c..a2581d2
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 183,190 ****
information about the timer selected during boot:
<screen>
! dmesg | grep "Timecounter"
! sysctl kern.timecounter.hardware=TSC
</screen>
</para>
--- 183,195 ----
information about the timer selected during boot:
<screen>
! # dmesg | grep "Timecounter"
! Timecounter "ACPI-fast" frequency 3579545 Hz quality 900
! Timecounter "i8254" frequency 1193182 Hz quality 0
! Timecounters tick every 10.000 msec
! Timecounter "TSC" frequency 2531787134 Hz quality 800
! # sysctl kern.timecounter.hardware=TSC
! kern.timecounter.hardware: ACPI-fast -> TSC
</screen>
</para>
*************** Histogram of timing durations:
*** 277,283 ****
</para>
<para>
! Timers used on older PC hardware including the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
--- 282,288 ----
</para>
<para>
! Timers used on older PC hardware include the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2012-08-30 22:38 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 20:21 pgtesttiming.sgml, FreeBSD command output Josh Kupershmidt <[email protected]>
2012-07-06 20:33 ` Peter Eisentraut <[email protected]>
2012-07-06 21:09 ` Josh Kupershmidt <[email protected]>
2012-08-30 22:38 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox