public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jonathan S. Katz <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Daniel Westermann <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Blanks in the first line before the first word in the code boxes
Date: Wed, 4 Apr 2018 09:21:32 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CABUevEw3sAROjdHW0OE4-i5+uM3VMHQTixtLT+SOWGJapYtaSw@mail.gmail.com>
	<[email protected]>
	<CABUevEw9hB8r_WjZ2KHZej1NS79xnQ=3R=zDFtAYsEiJdhTGpg@mail.gmail.com>
	<[email protected]>
	<CABUevEykw8e1kgd1AYAL5n0gBOXkaBXn1rRHhPc7bHTVgPwO0Q@mail.gmail.com>
	<[email protected]>


> On Apr 3, 2018, at 10:55 AM, Peter Eisentraut <[email protected]> wrote:
> 
> On 4/3/18 09:12, Magnus Hagander wrote:
>> I've pushed the fix and reloaded the 10 docs. I have not reloaded
>> earlier branches yet, but I'd be interested in some people reviewing a
>> bunch of pages in the 10 docs mainly to see if (1) it fixes all the
>> cases, and (2) it actually breaks some *other* cases. 
> 
> It looks correct now.

+1

Did a spot check on known broken pages and chose some others at
random. Viewed the 9.6, 10, and devel versions.  10 and devel both
looked correct, and the 9.6 was broken where expected.

The only thing I saw (and this may be something to look at the SGML
source) was some blocks that looked overly indented, but it was consistent
across all versions.  On

https://www.postgresql.org/docs/current/static/queries-with.html <https://www.postgresql.org/docs/current/static/queries-with.html;

If you search for "WITH RECURSIVE search_graph(id, link, data, depth)”
the expression in the CTE is much more indented than similar CTEs above
it.

IMV I would not let this stop us from reloading the earlier versions as that
indentation is consistent across all versions (including 9.6, where it has the
initial indentation as well).

Jonathan

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Blanks in the first line before the first word in the code boxes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox