From: Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Wrong example in the bloom documentation
Date: Sat, 17 Oct 2020 13:50:26 +0000
Message-ID: <GVAP278MB01022477E6F7AE58E207CF25D2000@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201015235019.GH3797@momjian.us>
References: <ZR0P278MB0122119FAE78721A694C30C8D2340@ZR0P278MB0122.CHEP278.PROD.OUTLOOK.COM>
<GVAP278MB01028F3C84C0A724412854EDD20B0@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
<20201008162310.GA13054@momjian.us>
<GVAP278MB010226D15C90933B3C2D198BD20B0@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
<2622731.1602186212@sss.pgh.pa.us>
<20201008195352.GA5062@momjian.us>
<GVAP278MB01026C00EA4E25E35062483FD2080@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
<20201009150832.GB1459@momjian.us>
<20201015235019.GH3797@momjian.us>
On Fri, Oct 9, 2020 at 11:08:32AM -0400, Bruce Momjian wrote:
> On Fri, Oct 9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote:
> > Hi Bruce, Tom,
> >
> > On Thu, Oct 8, 2020 at 03:43:32PM -0400, Tom Lane wrote:
> > >> "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com> writes:
> > >> >> I was hoping someone more experienced with this would comment, but
> > >> >> seeing none, I will apply it in a day or two to all supported versions?
> > >> >> Have you tested this output back to 9.5?
> > >>
> > >> > I hoped that as well. No, I tested down to 9.6 because the change happened in 10.
> > >>
> > >> The patch assumes that parallel query is enabled, which is not true by
> > >> default before v10, so it should certainly not be applied before v10
> > >> (at least not without significant revisions).
> >>
> >> Yes, the behavior change was in 10. Before 10 the example is fine, I would not apply that to any prior version, otherwise the whole example needs to be rewritten.
>>
>> Agreed.
>This is not applying to PG 12 or earlier because the patch mentions JIT,
>which was only mentioned in the PG bloom docs in PG 13+.
Does that mean we need separate patches for each release starting with 10?
As I am not frequently writing patches, I would need some help here.
Regards
Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: daniel.westermann@dbi-services.com, bruce@momjian.us, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Wrong example in the bloom documentation
In-Reply-To: <GVAP278MB01022477E6F7AE58E207CF25D2000@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox