From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema <me@jeltef.nl>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Add missing meson arguments in docs
Date: Wed, 22 Feb 2023 10:57:47 +0900
Message-ID: <Y/V2m04KR6A0K29U@paquier.xyz> (raw)
In-Reply-To: <CAGECzQRXd1z+AoQ4tC5tqPk1_NQJohf6xwdEL=z9KgxHau2maQ@mail.gmail.com>
References: <CAGECzQRXd1z+AoQ4tC5tqPk1_NQJohf6xwdEL=z9KgxHau2maQ@mail.gmail.com>
On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote:
> The -Dcassert and -Db_coverage of the meson build didn't show in the
> docs that they needed to be passed true or false. All other options
> specified the arguments they expected. This patch fixes that.
Indeed, values have to be specified after the equal sign of each
option, so applied what you are suggesting here.
-Db_coverage is part of the core options of meson because it is not
listed in meson_options.txt, no? Documenting the switch is fine, but
it seems like we lack contents here. The paragraph describing
-Db_coverage links to regress-coverage, still this only has
instructions for ./configure. Shouldn't we have some docs to show one
how to achieve the same with meson? I'd guess that a separate section
for meson would make the most sense, for as long as we support both
methods in parallel.
https://wiki.postgresql.org/wiki/Meson tells nothing about that, for
one.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Y%2FV2m04KR6A0K29U@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, me@jeltef.nl, pgsql-docs@lists.postgresql.org
Subject: Re: Add missing meson arguments in docs
In-Reply-To: <Y/V2m04KR6A0K29U@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox