From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: greenreaper@hotmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Naming of network_ops vs. inet_ops for SP-GIST
Date: Wed, 25 Jan 2023 11:45:22 +0900
Message-ID: <Y9CXwpxK/1j1a7vD@paquier.xyz> (raw)
In-Reply-To: <2314977.1674591764@sss.pgh.pa.us>
References: <167458110639.2667300.14741268666497110766@wrigleys.postgresql.org>
<2314977.1674591764@sss.pgh.pa.us>
On Tue, Jan 24, 2023 at 03:22:44PM -0500, Tom Lane wrote:
> I wonder whether we shouldn't just revert this table to
> showing opclass names, and avert our eyes from the theoretical
> inconsistency. Michael, looks like it was your 7a1cd5260
> that changed it; what do you think?
Yes, the docs should be fixed here. The intention is not to show the
operator families but the names of the opclasses. I can only spot one
difference in SpGiST for network_ops -> inet_ops as of the report.
BRIN, GIN and GiST look to be clean after a second lookup.
I don't have a strong opinion about the naming inconsistency between
the opclass name and the opfamily name in this case, though, couldn't
it create more problems than actually fix something?
Anyway, attached is a patch for the docs. Thoughts?
--
Michael
Attachments:
[text/x-diff] spgist-builtin.patch (2.1K, ../Y9CXwpxK%2F1j1a7vD@paquier.xyz/2-spgist-builtin.patch)
download | inline diff:diff --git a/doc/src/sgml/spgist.sgml b/doc/src/sgml/spgist.sgmlindex 00432512de..102f8627bd 100644--- a/doc/src/sgml/spgist.sgml+++ b/doc/src/sgml/spgist.sgml@@ -91,18 +91,7 @@
<row><entry><literal>|>> (box,box)</literal></entry></row>
<row>
- <entry valign="middle" morerows="5"><literal>kd_point_ops</literal></entry>- <entry><literal>|>> (point,point)</literal></entry>- <entry valign="middle" morerows="5"><literal><-> (point,point)</literal></entry>- </row>- <row><entry><literal><< (point,point)</literal></entry></row>- <row><entry><literal>>> (point,point)</literal></entry></row>- <row><entry><literal><<| (point,point)</literal></entry></row>- <row><entry><literal>~= (point,point)</literal></entry></row>- <row><entry><literal><@ (point,box)</literal></entry></row>-- <row>- <entry valign="middle" morerows="10"><literal>network_ops</literal></entry>+ <entry valign="middle" morerows="10"><literal>inet_ops</literal></entry>
<entry><literal><< (inet,inet)</literal></entry>
<entry valign="middle" morerows="10"></entry>
</row>
@@ -117,6 +106,17 @@
<row><entry><literal>>= (inet,inet)</literal></entry></row>
<row><entry><literal>&& (inet,inet)</literal></entry></row>
+ <row>+ <entry valign="middle" morerows="5"><literal>kd_point_ops</literal></entry>+ <entry><literal>|>> (point,point)</literal></entry>+ <entry valign="middle" morerows="5"><literal><-> (point,point)</literal></entry>+ </row>+ <row><entry><literal><< (point,point)</literal></entry></row>+ <row><entry><literal>>> (point,point)</literal></entry></row>+ <row><entry><literal><<| (point,point)</literal></entry></row>+ <row><entry><literal>~= (point,point)</literal></entry></row>+ <row><entry><literal><@ (point,box)</literal></entry></row>+
<row>
<entry valign="middle" morerows="11"><literal>poly_ops</literal></entry>
<entry><literal><< (polygon,polygon)</literal></entry>
[application/pgp-signature] signature.asc (832B, ../Y9CXwpxK%2F1j1a7vD@paquier.xyz/3-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, greenreaper@hotmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Naming of network_ops vs. inet_ops for SP-GIST
In-Reply-To: <Y9CXwpxK/1j1a7vD@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox