From: Michael Paquier <michael@paquier.xyz>
To: Erik Wienhold <ewie@ewie.name>
Cc: el481@yandex.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Misprints in code
Date: Mon, 25 Nov 2024 09:06:21 +0900
Message-ID: <Z0O_fd8tXxw12klx@paquier.xyz> (raw)
In-Reply-To: <fe60c0fa-cea7-4c6e-b951-28f566289550@ewie.name>
References: <173209043143.2092749.13692266486972491694@wrigleys.postgresql.org>
<fe60c0fa-cea7-4c6e-b951-28f566289550@ewie.name>
On Thu, Nov 21, 2024 at 04:31:07PM +0100, Erik Wienhold wrote:
> Good catch! That's a leftover from Python 2 and missed in commit
> 4228cabb72b after Python 2 was dropped in 15.0. Patch attached.
>
> While looking at, we can also simplify a couple of plpython3u test
> functions that still try res.next() before res.__next__(). Attached as
> a separate patch.
Sounds about right to me, the example greet() fails with plpython3.
For reference, this has been implemented in upstream here:
https://peps.python.org/pep-3114/
The existing tests of plpython mentioned this link, and I've bumped
over it again while looking for references on the matter.
Will fix. Thanks for the report!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Z0O_fd8tXxw12klx@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, ewie@ewie.name, el481@yandex.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Misprints in code
In-Reply-To: <Z0O_fd8tXxw12klx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox