From: Bruce Momjian <bruce@momjian.us>
To: andyatkinson@gmail.com
To: pgsql-docs@lists.postgresql.org
Subject: Re: [very minor] Documentation suggestion
Date: Fri, 27 Oct 2023 11:40:08 -0400
Message-ID: <ZTvZ2JGcoKoFxMUB@momjian.us> (raw)
In-Reply-To: <166631875298.630.2861049399528658047@wrigleys.postgresql.org>
References: <166631875298.630.2861049399528658047@wrigleys.postgresql.org>
On Fri, Oct 21, 2022 at 02:19:12AM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/15/logicaldecoding-synchronous.html
> Description:
>
> Very minor suggestion. Earlier on this page, commands are referred to that
> can cause "a deadlock". Later on the page, it says "cause deadlock".
>
> https://www.postgresql.org/account/comments/new/15/logicaldecoding-synchronous.html/
>
> "Note that these commands that can cause deadlock"
The full sentence is:
Note that these commands that can cause deadlock apply to not only
explicitly indicated system catalog tables above but also to any other
[user] catalog table.
What I think it means is:
Note that these commands, that can cause deadlock, apply to not only
explicitly indicated system catalog tables above but also to any other
[user] catalog table.
so with "a" it would be:
Note that these commands, that can cause a deadlock, apply to not only
explicitly indicated system catalog tables above but also to any other
[user] catalog table.
but it still needs help ;-) Here is the text I just applied:
Note that these commands can cause deadlocks not only for the system
catalog tables listed above but for other catalog tables.
Attached is the applied patch to master.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] master.diff (992B, ../ZTvZ2JGcoKoFxMUB@momjian.us/2-master.diff)
download | inline diff:
commit 16ace6f745
Author: Bruce Momjian <bruce@momjian.us>
Date: Fri Oct 27 11:35:47 2023 -0400
doc: clarify logical decoding's deadlock of system tables
Reported-by: andyatkinson@gmail.com
Discussion: https://postgr.es/m/166631875298.630.2861049399528658047@wrigleys.postgresql.org
Backpatch-through: master
diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgmlindex 5af016cfa9..8067946a25 100644--- a/doc/src/sgml/logicaldecoding.sgml+++ b/doc/src/sgml/logicaldecoding.sgml@@ -1197,9 +1197,8 @@ OutputPluginWrite(ctx, true);
</listitem>
</itemizedlist>
- Note that these commands that can cause deadlock apply to not only explicitly- indicated system catalog tables above but also to any other [user] catalog- table.+ Note that these commands can cause deadlocks not only for the system+ catalog tables listed above but for other catalog tables.
</para>
</sect2>
</sect1>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, andyatkinson@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: [very minor] Documentation suggestion
In-Reply-To: <ZTvZ2JGcoKoFxMUB@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox