pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
WAL Configuration Grammar Fix 2+ messages / 2 participants [nested] [flat]
* WAL Configuration Grammar Fix @ 2019-03-08 22:39 PG Doc comments form <noreply@postgresql.org> 0 siblings, 1 reply; 2+ messages in thread From: PG Doc comments form @ 2019-03-08 22:39 UTC (permalink / raw) To: pgsql-docs@lists.postgresql.org; +Cc: evan.macbeth@crunchydata.com The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/wal-configuration.html Description: On the WAL Configuration page - https://www.postgresql.org/docs/current/wal-configuration.html It reads: "On Linux and POSIX platforms checkpoint_flush_after allows to force the OS that pages written by the checkpoint should be flushed to disk after a configurable number of bytes." I believe a "you" is missing. I also suggest a more clear sentence construction might be: "On Linux and POSIX platforms you can use checkpoint_flush_after to set a configurable number of bytes after which the OS will be forced to flush to disk the pages written by the checkpoint." Respectfully submitted. Evan Macbeth ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: WAL Configuration Grammar Fix @ 2023-11-09 22:52 Bruce Momjian <bruce@momjian.us> parent: PG Doc comments form <noreply@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Bruce Momjian @ 2023-11-09 22:52 UTC (permalink / raw) To: evan.macbeth@crunchydata.com; pgsql-docs@lists.postgresql.org On Fri, Mar 8, 2019 at 10:39:16PM +0000, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/wal-configuration.html > Description: > > On the WAL Configuration page - > https://www.postgresql.org/docs/current/wal-configuration.html > It reads: "On Linux and POSIX platforms checkpoint_flush_after allows to > force the OS that pages written by the checkpoint should be flushed to disk > after a configurable number of bytes." > > I believe a "you" is missing. I also suggest a more clear sentence > construction might be: > "On Linux and POSIX platforms you can use checkpoint_flush_after to set a > configurable number of bytes after which the OS will be forced to flush to > disk the pages written by the checkpoint." This patch is 4.5 years old, but still valid. Fixed with the attached patch applied to master. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. Attachments: [text/x-diff] master.diff (629B, ../../ZU1iqgtsMMze2ATJ@momjian.us/2-master.diff) download | inline diff: diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml index 4aad0e1a07..184404c6c5 100644 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@ -602,7 +602,7 @@ <para> On Linux and POSIX platforms <xref linkend="guc-checkpoint-flush-after"/> - allows to force the OS that pages written by the checkpoint should be + allows you to force OS pages written by the checkpoint to be flushed to disk after a configurable number of bytes. Otherwise, these pages may be kept in the OS's page cache, inducing a stall when <literal>fsync</literal> is issued at the end of a checkpoint. This setting will ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-11-09 22:52 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-03-08 22:39 WAL Configuration Grammar Fix PG Doc comments form <noreply@postgresql.org> 2023-11-09 22:52 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox