From: Bruce Momjian <bruce@momjian.us>
To: evan.macbeth@crunchydata.com
To: pgsql-docs@lists.postgresql.org
Subject: Re: WAL Configuration Grammar Fix
Date: Thu, 9 Nov 2023 17:52:26 -0500
Message-ID: <ZU1iqgtsMMze2ATJ@momjian.us> (raw)
In-Reply-To: <155208475619.1380.12815553062985622271@wrigleys.postgresql.org>
References: <155208475619.1380.12815553062985622271@wrigleys.postgresql.org>
On Fri, Mar 8, 2019 at 10:39:16PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/11/wal-configuration.html
> Description:
>
> On the WAL Configuration page -
> https://www.postgresql.org/docs/current/wal-configuration.html
> It reads: "On Linux and POSIX platforms checkpoint_flush_after allows to
> force the OS that pages written by the checkpoint should be flushed to disk
> after a configurable number of bytes."
>
> I believe a "you" is missing. I also suggest a more clear sentence
> construction might be:
> "On Linux and POSIX platforms you can use checkpoint_flush_after to set a
> configurable number of bytes after which the OS will be forced to flush to
> disk the pages written by the checkpoint."
This patch is 4.5 years old, but still valid. Fixed with the attached
patch applied to master.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] master.diff (629B, ../ZU1iqgtsMMze2ATJ@momjian.us/2-master.diff)
download | inline diff:diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgmlindex 4aad0e1a07..184404c6c5 100644--- a/doc/src/sgml/wal.sgml+++ b/doc/src/sgml/wal.sgml@@ -602,7 +602,7 @@
<para>
On Linux and POSIX platforms <xref linkend="guc-checkpoint-flush-after"/>
- allows to force the OS that pages written by the checkpoint should be+ allows you to force OS pages written by the checkpoint to be
flushed to disk after a configurable number of bytes. Otherwise, these
pages may be kept in the OS's page cache, inducing a stall when
<literal>fsync</literal> is issued at the end of a checkpoint. This setting will
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, evan.macbeth@crunchydata.com, pgsql-docs@lists.postgresql.org
Subject: Re: WAL Configuration Grammar Fix
In-Reply-To: <ZU1iqgtsMMze2ATJ@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox