pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feed"22.3. Template Databases" documentation is incomplete
6+ messages / 3 participants
[nested] [flat]
* "22.3. Template Databases" documentation is incomplete
@ 2022-08-09 20:33 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2022-08-09 20:33 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: david@kapitaltrading.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/14/manage-ag-templatedbs.html
Description:
The documentation for creating databases from templates is incomplete, and
should mention that access privileges are not copied. So, for example,
issuing:
create database newdb with template existingdb owner someuser;
results in the newly-created database lacking the access privileges that
exist in the template.
cf: https://www.postgresql.org/docs/13/manage-ag-templatedbs.html
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: "22.3. Template Databases" documentation is incomplete
@ 2023-10-28 16:18 Bruce Momjian <bruce@momjian.us>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2023-10-28 16:18 UTC (permalink / raw)
To: david@kapitaltrading.com; pgsql-docs@lists.postgresql.org
On Tue, Aug 9, 2022 at 08:33:11PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/14/manage-ag-templatedbs.html
> Description:
>
> The documentation for creating databases from templates is incomplete, and
> should mention that access privileges are not copied. So, for example,
> issuing:
>
> create database newdb with template existingdb owner someuser;
>
> results in the newly-created database lacking the access privileges that
> exist in the template.
>
> cf: https://www.postgresql.org/docs/13/manage-ag-templatedbs.html
I have created the attached patch to document this.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] template.diff (721B, ../../ZT00aqNUUQxhXHBo@momjian.us/2-template.diff)
download | inline diff:
[1mdiff --git a/doc/src/sgml/manage-ag.sgml b/doc/src/sgml/manage-ag.sgml[m
[1mindex 192c500994..b852783a6c 100644[m
[1m--- a/doc/src/sgml/manage-ag.sgml[m
[1m+++ b/doc/src/sgml/manage-ag.sgml[m
[36m@@ -210,7 +210,8 @@[m [mcreatedb -O <replaceable>rolename</replaceable> <replaceable>dbname</replaceable[m
objects in databases. For example, if you install the procedural[m
language <application>PL/Perl</application> in <literal>template1</literal>, it will[m
automatically be available in user databases without any extra[m
action being taken when those databases are created. [32mIt does not copy[m
[32m database-level <command>GRANT</command> permissions.[m
</para>[m
<para>[m
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: "22.3. Template Databases" documentation is incomplete
@ 2023-10-28 16:42 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2023-10-28 16:42 UTC (permalink / raw)
To: david@kapitaltrading.com; pgsql-docs@lists.postgresql.org
On Sat, Oct 28, 2023 at 12:18:50PM -0400, Bruce Momjian wrote:
> On Tue, Aug 9, 2022 at 08:33:11PM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/14/manage-ag-templatedbs.html
> > Description:
> >
> > The documentation for creating databases from templates is incomplete, and
> > should mention that access privileges are not copied. So, for example,
> > issuing:
> >
> > create database newdb with template existingdb owner someuser;
> >
> > results in the newly-created database lacking the access privileges that
> > exist in the template.
> >
> > cf: https://www.postgresql.org/docs/13/manage-ag-templatedbs.html
>
> I have created the attached patch to document this.
Sorry, I attached a _colorized_ diff; here is a normal one.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] template.diff (713B, ../../ZT06EOE2dDdEklEY@momjian.us/2-template.diff)
download | inline diff:
diff --git a/doc/src/sgml/manage-ag.sgml b/doc/src/sgml/manage-ag.sgml
index 192c500994..b852783a6c 100644
--- a/doc/src/sgml/manage-ag.sgml
+++ b/doc/src/sgml/manage-ag.sgml
@@ -210,7 +210,8 @@ createdb -O <replaceable>rolename</replaceable> <replaceable>dbname</replaceable
objects in databases. For example, if you install the procedural
language <application>PL/Perl</application> in <literal>template1</literal>, it will
automatically be available in user databases without any extra
- action being taken when those databases are created.
+ action being taken when those databases are created. It does not copy
+ database-level <command>GRANT</command> permissions.
</para>
<para>
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: "22.3. Template Databases" documentation is incomplete
@ 2023-10-28 18:42 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2023-10-28 18:42 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: david@kapitaltrading.com; pgsql-docs@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> Sorry, I attached a _colorized_ diff; here is a normal one.
The new sentence is fine in isolation, but this doesn't feel like
a great spot to put it. The preceding several lines are all about
copying of objects within the database, and this isn't. In
particular, the antecedent of "it" is unclear and is different
from what "it" means in the immediately preceding sentence.
It might be best to split the thing out into its own para?
Something like
action being taken when those databases are created.
</para>
+ <para>
+ However, <command>CREATE DATABASE</command> does not copy
+ database-level <command>GRANT</command> permissions attached to the
+ source database. The new database has default permissions.
+ </para>
+
<para>
There is a second standard system database named
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: "22.3. Template Databases" documentation is incomplete
@ 2023-10-28 19:14 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2023-10-28 19:14 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: david@kapitaltrading.com; pgsql-docs@lists.postgresql.org
On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Sorry, I attached a _colorized_ diff; here is a normal one.
>
> The new sentence is fine in isolation, but this doesn't feel like
> a great spot to put it. The preceding several lines are all about
> copying of objects within the database, and this isn't. In
> particular, the antecedent of "it" is unclear and is different
> from what "it" means in the immediately preceding sentence.
>
> It might be best to split the thing out into its own para?
> Something like
>
> action being taken when those databases are created.
> </para>
>
> + <para>
> + However, <command>CREATE DATABASE</command> does not copy
> + database-level <command>GRANT</command> permissions attached to the
> + source database. The new database has default permissions.
> + </para>
> +
> <para>
> There is a second standard system database named
Sure.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: "22.3. Template Databases" documentation is incomplete
@ 2023-11-03 17:40 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2023-11-03 17:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: david@kapitaltrading.com; pgsql-docs@lists.postgresql.org
On Sat, Oct 28, 2023 at 03:14:32PM -0400, Bruce Momjian wrote:
> On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Sorry, I attached a _colorized_ diff; here is a normal one.
> >
> > The new sentence is fine in isolation, but this doesn't feel like
> > a great spot to put it. The preceding several lines are all about
> > copying of objects within the database, and this isn't. In
> > particular, the antecedent of "it" is unclear and is different
> > from what "it" means in the immediately preceding sentence.
> >
> > It might be best to split the thing out into its own para?
> > Something like
> >
> > action being taken when those databases are created.
> > </para>
> >
> > + <para>
> > + However, <command>CREATE DATABASE</command> does not copy
> > + database-level <command>GRANT</command> permissions attached to the
> > + source database. The new database has default permissions.
> > + </para>
> > +
> > <para>
> > There is a second standard system database named
>
> Sure.
Separate paragraph version applied to all supported versions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-11-03 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09 20:33 "22.3. Template Databases" documentation is incomplete PG Doc comments form <noreply@postgresql.org>
2023-10-28 16:18 ` Bruce Momjian <bruce@momjian.us>
2023-10-28 16:42 ` Bruce Momjian <bruce@momjian.us>
2023-10-28 18:42 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-10-28 19:14 ` Bruce Momjian <bruce@momjian.us>
2023-11-03 17:40 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox