agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Table rewrite supporting functions for event triggers
Date: Tue, 29 Oct 2024 15:40:48 +0900
Message-ID: <ZyCDcO8ZigR-41gL@paquier.xyz> (raw)
In-Reply-To: <ZuNtkd5IJ0TipHzo@paquier.xyz>
References: <CAKAnmmL+Z6j-C8dAx1tVrnBmZJu+BSoc68WSg3sR+CVNjBCqbw@mail.gmail.com>
<718fcf4a067b576b501bd5b18b54a1fdc4fda639.camel@cybertec.at>
<CAKAnmm+SfSEg+bmWqT5Q9BSTU3FGaSquVebrQ+8jg3Dq-_1vxg@mail.gmail.com>
<CAKAnmm+NKVhZMjNN8okbPHXMxSb0Ngqhxgt4hEMGU=RWq9fnKA@mail.gmail.com>
<c264f34792b17f5bd30133071cfa252919bf5323.camel@cybertec.at>
<ZuEx_09-ohYExkJG@paquier.xyz>
<CAKAnmmJ-DXh4QDjS8Aiz8SBxDWrcj1Epq54byb8T_035nTX2JQ@mail.gmail.com>
<ZuJdSA9U5OmgagbS@paquier.xyz>
<CAKAnmmLOq8DPfd14Wj+gmn8vH4nUY0_NrWiHL0gQGxXj2SCW4g@mail.gmail.com>
<ZuNtkd5IJ0TipHzo@paquier.xyz>
On Fri, Sep 13, 2024 at 07:39:13AM +0900, Michael Paquier wrote:
> I am not so sure, TBH. One example: I know these values in
> tablecmds.c for some time because that's an area I tend to focus on
> for bug fixes, but forgot entirely about the SQL function in event
> triggers that feed on it until I found your post. A comment in
> event_trigger.h to mention the doc update would work for me. That
> would be impossible to miss.
My apologies for the delay in replying here. I've looked back at your
proposal in 0002 to mention the two functions in the main section for
event triggers and to add a description of the reson values in the
bitmap. After adding a comment in event_trigger.h to tell that the
documentation needs to be kept in sync, the result looked OK so I have
applied that down to 13.
1ad23335f36b got in the way for 12 with some conflicts. As it is
going to be EOL in a few days, it does not really matter much.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZyCDcO8ZigR-41gL@paquier.xyz/2-signature.asc)
download
view thread (11+ messages)
Message-ID: <ZyCDcO8ZigR-41gL@paquier.xyz>
Permalink: ../ZyCDcO8ZigR-41gL@paquier.xyz/
Also on: postgresql.org/message-id/ZyCDcO8ZigR-41gL@paquier.xyz
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, htamfids@gmail.com, laurenz.albe@cybertec.at, pgsql-docs@lists.postgresql.org
Subject: Re: Table rewrite supporting functions for event triggers
In-Reply-To: <ZyCDcO8ZigR-41gL@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox