pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedNot an error but a difficult wording
5+ messages / 3 participants
[nested] [flat]
* Not an error but a difficult wording
@ 2023-01-25 08:22 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: PG Doc comments form @ 2023-01-25 08:22 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: riivo.kolka@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/15/sourcerepo.html
Description:
https://www.postgresql.org/docs/current/sourcerepo.html
I was convinced that there was a missing word or something in
"because the files that these tools are used to build are included in the
tarball"
I had to read this several times, until I saw that it was actually
correct.
Maybe this would be better? (I don't know the comma rules)
"because the files(,?) that are generated/processed by these tools(,?) are
already included in the tarball"
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Not an error but a difficult wording
@ 2023-01-25 22:21 Laurenz Albe <laurenz.albe@cybertec.at>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: Laurenz Albe @ 2023-01-25 22:21 UTC (permalink / raw)
To: riivo.kolka@gmail.com; pgsql-docs@lists.postgresql.org
On Wed, 2023-01-25 at 08:22 +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/15/sourcerepo.html
> Description:
>
> https://www.postgresql.org/docs/current/sourcerepo.html
>
> I was convinced that there was a missing word or something in
> "because the files that these tools are used to build are included in the
> tarball"
> I had to read this several times, until I saw that it was actually
> correct.
>
> Maybe this would be better? (I don't know the comma rules)
> "because the files(,?) that are generated/processed by these tools(,?) are
> already included in the tarball"
+1
Correct English would be:
These tools are not needed to build from a distribution tarball, because
the files generated by these tools are included in the tarball.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Not an error but a difficult wording
@ 2023-01-26 01:39 Tom Lane <tgl@sss.pgh.pa.us>
parent: Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2023-01-26 01:39 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: riivo.kolka@gmail.com; pgsql-docs@lists.postgresql.org
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Wed, 2023-01-25 at 08:22 +0000, PG Doc comments form wrote:
>> Maybe this would be better? (I don't know the comma rules)
>> "because the files(,?) that are generated/processed by these tools(,?) are
>> already included in the tarball"
> +1
> Correct English would be:
> These tools are not needed to build from a distribution tarball, because
> the files generated by these tools are included in the tarball.
The existing wording is not incorrect AFAICS, but I agree it's a bit
awkward. I'd modify one word in your version:
These tools are not needed to build from a distribution tarball, because
the files generated using these tools are included in the tarball.
Or possibly "with" instead of "using"?
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Not an error but a difficult wording
@ 2023-01-26 04:49 Laurenz Albe <laurenz.albe@cybertec.at>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: Laurenz Albe @ 2023-01-26 04:49 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: riivo.kolka@gmail.com; pgsql-docs@lists.postgresql.org
On Wed, 2023-01-25 at 20:39 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > On Wed, 2023-01-25 at 08:22 +0000, PG Doc comments form wrote:
> > > Maybe this would be better? (I don't know the comma rules)
> > > "because the files(,?) that are generated/processed by these tools(,?) are
> > > already included in the tarball"
>
> > +1
>
> > Correct English would be:
>
> > These tools are not needed to build from a distribution tarball, because
> > the files generated by these tools are included in the tarball.
>
> The existing wording is not incorrect AFAICS, but I agree it's a bit
> awkward.
I meant "a correct version of what was suggested in the mail", not that
the released text was incorrect.
> I'd modify one word in your version:
>
> These tools are not needed to build from a distribution tarball, because
> the files generated using these tools are included in the tarball.
>
> Or possibly "with" instead of "using"?
Both are better; I'd lean towards "with".
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Not an error but a difficult wording
@ 2023-01-26 16:34 Tom Lane <tgl@sss.pgh.pa.us>
parent: Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2023-01-26 16:34 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: riivo.kolka@gmail.com; pgsql-docs@lists.postgresql.org
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Wed, 2023-01-25 at 20:39 -0500, Tom Lane wrote:
>> I'd modify one word in your version:
>>
>> These tools are not needed to build from a distribution tarball, because
>> the files generated using these tools are included in the tarball.
>>
>> Or possibly "with" instead of "using"?
> Both are better; I'd lean towards "with".
Done that way then, thanks.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2023-01-26 16:34 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 08:22 Not an error but a difficult wording PG Doc comments form <noreply@postgresql.org>
2023-01-25 22:21 ` Laurenz Albe <laurenz.albe@cybertec.at>
2023-01-26 01:39 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-01-26 04:49 ` Laurenz Albe <laurenz.albe@cybertec.at>
2023-01-26 16:34 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox