public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL-documentation <[email protected]>
Subject: Re: Quoting of *_command arguments
Date: Fri, 14 Nov 2025 09:09:45 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Wed, Nov 12, 2025 at 08:48:39AM -0500, Bruce Momjian wrote:
> On Wed, Nov 12, 2025 at 02:45:16PM +0100, Peter Eisentraut wrote:
> > On 11.11.25 20:31, Bruce Momjian wrote:
> > > We inconsistently double-quote the "%f" and "%p" arguments of
> > > "archive_command" and "restore_command".  Paths with spaces or special
> > > characters, especially directory names in these cases, would need
> > > double-quotes.
> > > 
> > > This patch adds double-quotes to all instances.  I can also go the other
> > > way and remove them all, but we should be consistent.
> > 
> > I think %f doesn't need to be quoted because it will only contain certain
> > characters, but if we tried to clarify that it would probably be too
> > confusing.  It makes sense to nudge people that some quoting is prudent.
> 
> Yeah, I did consider your point but you are right --- it is too complex
> to quote one and not the other and expect people to understand why.
> 
> > Your patch looks good to me.
> 
> Thanks.

Applied, and I added double-quotes for "%r".

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Quoting of *_command arguments
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox