From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: SPITupleTable members missing in docs
Date: Wed, 17 Jul 2019 18:12:02 +0000 (GMT)
Message-ID: <alpine.DEB.2.21.1907171809000.6887@lancre> (raw)
In-Reply-To: <A54A61CA-9354-4745-908F-9083CEE6237D@yesql.se>
References: <0D19F836-B743-4340-B6A2-F148CA3DD1F0@yesql.se>
<alpine.DEB.2.21.1907121649180.8895@lancre>
<4584.1562943879@sss.pgh.pa.us>
<E3EABCE1-0B95-4091-9679-DAB065904F97@yesql.se>
<alpine.DEB.2.21.1907152310470.8986@lancre>
<A54A61CA-9354-4745-908F-9083CEE6237D@yesql.se>
>>> I quite like this suggestion, so I’ve changed the patch to do this. Removed
>>> the doc: in the commit message to indicate that this is no longer just touching
>>> documentation.
>>
>> About v2: applies cleanly, compiles, make check and doc gen ok.
>>
>> However, the documentation does not look right, field comments are not
>> aligned. Do not use tabs in the sgml file, use spaces only, otherwise
>> the display layout is left to chance.
>
> Of course, that was me fat-fingering. Fixed in the attached v3.
> Thanks for reviewing!
V3 fixes the html display alignment issue. Patch marked as ready.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: coelho@cri.ensmp.fr, daniel@yesql.se, tgl@sss.pgh.pa.us, michael@paquier.xyz
Subject: Re: SPITupleTable members missing in docs
In-Reply-To: <alpine.DEB.2.21.1907171809000.6887@lancre>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox