public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: Oleg <[email protected]>
Cc: [email protected]
Subject: Re: Documentation improvement patch
Date: Wed, 19 Nov 2025 12:02:23 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 14.11.25 10:04, Daniel Gustafsson wrote:
>> On 30 Oct 2025, at 11:15, Peter Eisentraut <[email protected]> wrote:
> 
>> -       Change the definition of a replication slot.
>> +       Changes the definition of a replication slot.
>>
>> I think these are intentionally written in imperative style.  Compare the synopses of the main SQL commands: "change the definition of a domain" etc.
> 
> I agree, I too think these are intentionally written like this.  The document
> isn't entirely consistent and does mix style quite a bit but I don't think
> these changes change the needle enough to make.

The following changes are left in your patch that should not be changed 
per the above discussion (all in doc/src/sgml/protocol.sgml):

-       Create a physical or logical replication
+       Creates a physical or logical replication

-       Instructs server to start streaming WAL, starting at
+       Instructs the server to start streaming WAL, starting at

-       Instructs server to start streaming WAL for logical replication,
+       Instructs the server to start streaming WAL for logical replication,

Separately, maybe this could be improved further:

-        Sets the maximum number of open files each server subprocess is
+        Sets the maximum number of files each server subprocess is
          allowed to open simultaneously;  files already opened in the

I think it would be more correct to say something like "... number of 
files each server subprocess is allowed to have open simultaneously ..." 
(not how many open actions are happening concurrently).

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Documentation improvement patch
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox