pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedMisleading
3+ messages / 3 participants
[nested] [flat]
* Misleading
@ 2017-03-28 11:02 marek.cvoren@gmail.com
0 siblings, 1 reply; 3+ messages in thread
From: marek.cvoren@gmail.com @ 2017-03-28 11:02 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/9.6/static/pgupgrade.html
Description:
Hello,
Please correct following part of pg_upgrade documentation:
`You can also specify user and port values, and whether you want the data
linked instead of copied (the default).`
It is not clear what is the default option. If you read the whole sentence,
then context might be misinterpreted to `data linked instead of copied` is
default but you meant that copying is default. Please correct this as it is
confusing and can lead someone to big troubles.
My suggestion:
- completely omit confusing default word:
`You can also specify user and port values, and whether you want the data
linked instead of copied.`
Thank you.
Cheers,
Marek
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Misleading
@ 2017-04-05 04:28 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
parent: marek.cvoren@gmail.com
0 siblings, 1 reply; 3+ messages in thread
From: Peter Eisentraut @ 2017-04-05 04:28 UTC (permalink / raw)
To: marek.cvoren@gmail.com; pgsql-docs
On 3/28/17 07:02, marek.cvoren@gmail.com wrote:
> Please correct following part of pg_upgrade documentation:
> `You can also specify user and port values, and whether you want the data
> linked instead of copied (the default).`
>
> It is not clear what is the default option. If you read the whole sentence,
> then context might be misinterpreted to `data linked instead of copied` is
> default but you meant that copying is default. Please correct this as it is
> confusing and can lead someone to big troubles.
>
> My suggestion:
> - completely omit confusing default word:
> `You can also specify user and port values, and whether you want the data
> linked instead of copied.`
It's debatable whether that sentence is unclear, I think, but the change
you propose actually loses the information about what mode is the
default, which wouldn't be good.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Misleading
@ 2017-04-11 16:14 Bruce Momjian <bruce@momjian.us>
parent: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Momjian @ 2017-04-11 16:14 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: marek.cvoren@gmail.com; pgsql-docs
On Wed, Apr 5, 2017 at 12:28:46AM -0400, Peter Eisentraut wrote:
> On 3/28/17 07:02, marek.cvoren@gmail.com wrote:
> > My suggestion:
> > - completely omit confusing default word:
> > `You can also specify user and port values, and whether you want the data
> > linked instead of copied.`
>
> It's debatable whether that sentence is unclear, I think, but the change
> you propose actually loses the information about what mode is the
> default, which wouldn't be good.
I have applied the attached doc patch to clarify this.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
pg_upgrade.diff (text/x-diff, 1.1K) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
new file mode 100644
index 49aaf51..bf58a0a
*** a/doc/src/sgml/ref/pgupgrade.sgml
--- b/doc/src/sgml/ref/pgupgrade.sgml
*************** NET STOP postgresql-9.0
*** 336,343 ****
Always run the <application>pg_upgrade</> binary of the new server, not the old one.
<application>pg_upgrade</> requires the specification of the old and new cluster's
data and executable (<filename>bin</>) directories. You can also specify
! user and port values, and whether you want the data linked instead of
! copied (the default).
</para>
<para>
--- 336,343 ----
Always run the <application>pg_upgrade</> binary of the new server, not the old one.
<application>pg_upgrade</> requires the specification of the old and new cluster's
data and executable (<filename>bin</>) directories. You can also specify
! user and port values, and whether you want the data files linked
! instead of the default copy behavior.
</para>
<para>
end of thread, other threads:[~2017-04-11 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 11:02 Misleading marek.cvoren@gmail.com
2017-04-05 04:28 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-04-11 16:14 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox