From: Jonathan S. Katz <jkatz@postgresql.org>
To: Joe Conway <mail@joeconway.com>
To: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Steven Winfield <Steven.Winfield@cantabcapital.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Cc: Jonathan S. Katz <jonathan.katz@excoventures.com>
Subject: Re: SET ROLE documentation not entirely correct
Date: Fri, 26 Apr 2019 15:04:45 -0400
Message-ID: <dc5b0391-ad27-4738-7942-50bf3fbd8523@postgresql.org> (raw)
In-Reply-To: <3ef761db-1e39-5d13-c7e6-be785da2907e@joeconway.com>
References: <155603476764.1372.10888362840885095061@wrigleys.postgresql.org>
<03796ce5-8366-cd32-0436-9981ffbeb993@joeconway.com>
<E9FA92C2921F31408041863B74EE4C2001BD62E4D4@CCPMAILDAG03.cantab.local>
<c7dfb7a9-f9d9-245c-1b8a-4d5c1cea6a00@joeconway.com>
<E9FA92C2921F31408041863B74EE4C2001BD62EB76@CCPMAILDAG03.cantab.local>
<67c97dbc-9caf-aa7e-622a-e20b28b7e597@joeconway.com>
<02e17cb3-f8a9-234f-f3ce-2b80bc49031d@joeconway.com>
<26109.1556217198@sss.pgh.pa.us>
<20190425190626.GY6197@tamriel.snowman.net>
<97c6e8d5-7e51-5cd2-4fc2-652ad02659d9@joeconway.com>
<eb139a20-811b-91ed-fbe3-00968c614425@postgresql.org>
<6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org>
<ebe8e6e0-859e-7b5c-6813-2dbdcc07fac9@joeconway.com>
<0a062c73-68e7-9890-ab68-cd3e50842df0@postgresql.org>
<3ef761db-1e39-5d13-c7e6-be785da2907e@joeconway.com>
On 4/25/19 6:54 PM, Joe Conway wrote:
> On 4/25/19 5:59 PM, Jonathan S. Katz wrote:
>> On 4/25/19 5:26 PM, Joe Conway wrote:
>>>
>>> Is there any written instruction anywhere with guidance on how the SVGs
>>> should be made?
>>
>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/images/README;
>
> Awesome -- that is what I had been looking for. Shouldn't we add that to
> the actual documentation style guide?
>
>> but I would suggest we had some guidance on how to ensure the image
>> stays scalable.
>
> Since you seem to know the magic incarnations, can you propose some words?
Please see attached.
Jonathan
diff --git a/doc/src/sgml/images/README b/doc/src/sgml/images/READMEindex dd29486a09..81b426c066 100644--- a/doc/src/sgml/images/README+++ b/doc/src/sgml/images/README@@ -59,3 +59,10 @@ Notes:
- The width should be set to something. This ensures that the image
is scaled to fit the page in PDF output. (Other widths than 100%
might be appropriate.)
++- SVG images should be scalable as they will be rendered in a variety+ of places (web, PDF, etc.) as well as in different viewports+ (desktop, mobile, etc.). To help the images successfully scale,+ please employe a "viewBox" attribute in the svg tag. For example,+ to set an image to contain a default width and heigh of 400x300,+ you would use viewBox="0.00 0.00 400.00 300.00"Attachments:
[text/plain] viewBox.patch (754B, ../dc5b0391-ad27-4738-7942-50bf3fbd8523@postgresql.org/2-viewBox.patch)
download | inline diff:diff --git a/doc/src/sgml/images/README b/doc/src/sgml/images/READMEindex dd29486a09..81b426c066 100644--- a/doc/src/sgml/images/README+++ b/doc/src/sgml/images/README@@ -59,3 +59,10 @@ Notes:
- The width should be set to something. This ensures that the image
is scaled to fit the page in PDF output. (Other widths than 100%
might be appropriate.)
++- SVG images should be scalable as they will be rendered in a variety+ of places (web, PDF, etc.) as well as in different viewports+ (desktop, mobile, etc.). To help the images successfully scale,+ please employe a "viewBox" attribute in the svg tag. For example,+ to set an image to contain a default width and heigh of 400x300,+ you would use viewBox="0.00 0.00 400.00 300.00"
[application/pgp-signature] signature.asc (832B, ../dc5b0391-ad27-4738-7942-50bf3fbd8523@postgresql.org/3-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: jkatz@postgresql.org, mail@joeconway.com, sfrost@snowman.net, tgl@sss.pgh.pa.us, Steven.Winfield@cantabcapital.com, pgsql-docs@lists.postgresql.org, jonathan.katz@excoventures.com
Subject: Re: SET ROLE documentation not entirely correct
In-Reply-To: <dc5b0391-ad27-4738-7942-50bf3fbd8523@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox