pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Fixes for create subscription page
10+ messages / 5 participants
[nested] [flat]

* Fixes for create subscription page
@ 2026-10-07 10:58  Thom Brown <thom@linux.com>
  0 siblings, 2 replies; 10+ messages in thread

From: Thom Brown @ 2026-10-07 10:58 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org

Hi,

I was looking through the new options for create subscription, and
found issues with some of the text, so I reviewed the whole page.
Attached are my proposed changes.

Regards

Thom

Attachments:

create_subscription_changes.patch (text/x-patch, 5.1K) download diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 6248c228a64..7d9601a7bfb 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -141,9 +141,9 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> Since no connection is made when this option is - <literal>false</literal>, no tables and sequences are subscribed. To + <literal>false</literal>, no tables or sequences are subscribed. To initiate replication, you must manually create the replication slot, - enable the failover if required, enable the subscription, and refresh + enable failover if required, enable the subscription, and refresh the subscription. See <xref linkend="logical-replication-subscription-examples-deferred-slot"/> for examples. @@ -184,7 +184,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> Name of the publisher's replication slot to use. The default is to use the name of the subscription for the slot name. The name cannot - be <literal>pg_conflict_detection</literal> as it is reserved for the + be <literal>pg_conflict_detection</literal> as it is reserved for conflict detection. </para> @@ -240,7 +240,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl format. Even when this option is enabled, only data types having binary send and receive functions will be transferred in binary. Note that the initial synchronization requires all data types to have binary - send and receive functions, otherwise the synchronization will fail + send and receive functions, otherwise synchronization will fail (see <xref linkend="sql-createtype"/> for more about send/receive functions). This parameter has no effect for sequences. </para> @@ -555,7 +555,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl Additionally when enabling <literal>retain_dead_tuples</literal> for conflict detection in logical replication, it is important to design the replication topology to balance data retention requirements with - overall system performance. This option provides minimal performance + overall system performance. This option incurs minimal performance overhead when applied appropriately. The following scenarios illustrate effective usage patterns when enabling this option. </para> @@ -581,9 +581,9 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl c. Read-Only Subscribers: In configurations involving single or multiple publisher nodes performing concurrent write operations, read-only subscriber nodes may - replicate changes without seeing a performance impact if it does index - scan. However, if the subscriber is impacted due to replication lag or - scan performance (say due to sequential scans), it needs to follow one + replicate changes without performance degradation if performing index + scans. However, if the subscriber is affected due to replication lag or + scan performance (e.g. due to sequential scans), it needs to follow one of the two previous strategies to distribute the workload on the subscriber. </para> @@ -636,9 +636,10 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl can be manually resumed by re-enabling <literal>retain_dead_tuples</literal>. </para> <para> - Note that overall retention will not stop if other subscriptions that - have a value greater than 0 for this parameter have not exceeded it, - or if they set this option to 0. + Note that overall retention will not stop while any other subscription + with <literal>retain_dead_tuples</literal> enabled either has this + option set to <literal>0</literal> or has not yet exceeded its nonzero + limit. </para> <para> This option is effective only when @@ -699,7 +700,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> See <xref linkend="logical-replication-security"/> for details on how to configure access control between the subscription and the - publication instance. + publisher instance. </para> <para> @@ -769,7 +770,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl originated from further upstream. This scenario is detected and a WARNING is logged to the user, but the warning is only an indication of a potential problem; it is the user's responsibility to make the necessary checks to - ensure the copied data origins are really as wanted or not. + ensure the origins of the copied data are as intended. </para> <para>
^ permalink raw reply [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-07 14:32  Laurenz Albe <laurenz.albe@cybertec.at>
  parent: Thom Brown <thom@linux.com>
  1 sibling, 1 reply; 10+ messages in thread

From: Laurenz Albe @ 2026-10-07 14:32 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; pgsql-docs@lists.postgresql.org

On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote:
> I was looking through the new options for create subscription, and
> found issues with some of the text, so I reviewed the whole page.
> Attached are my proposed changes.

Thanks!

I agree with most of your changes, but have doubts about a few:

> --- a/doc/src/sgml/ref/create_subscription.sgml
> +++ b/doc/src/sgml/ref/create_subscription.sgml

>           <para>
>            Since no connection is made when this option is
> -          <literal>false</literal>, no tables and sequences are subscribed. To
> +          <literal>false</literal>, no tables or sequences are subscribed. To

Hm.  I think "and" would be the better conjunction here (although "or"
is not really wrong).

>            send and receive functions will be transferred in binary. Note that
>            the initial synchronization requires all data types to have binary
> -          send and receive functions, otherwise the synchronization will fail
> +          send and receive functions, otherwise synchronization will fail
>            (see <xref linkend="sql-createtype"/> for more about send/receive
>            functions). This parameter has no effect for sequences.

My feeling is that the article is correct here (disclaimer: I am not
a native speaker).

> -           overall system performance. This option provides minimal performance
> +           overall system performance. This option incurs minimal performance
>             overhead when applied appropriately. The following scenarios illustrate

I see your point, although you could argue that "minimal performance overhead"
is a feature, and you provide a feature rather than incur it.
How about "provides reduced performance overhead"?

>             c. Read-Only Subscribers:
>             In configurations involving single or multiple publisher nodes
>             performing concurrent write operations, read-only subscriber nodes may
> -           replicate changes without seeing a performance impact if it does index
> -           scan. However, if the subscriber is impacted due to replication lag or
> -           scan performance (say due to sequential scans), it needs to follow one
> +           replicate changes without performance degradation if performing index
> +           scans. However, if the subscriber is affected due to replication lag or
> +           scan performance (e.g. due to sequential scans), it needs to follow one
>             of the two previous strategies to distribute the workload on the
>             subscriber.

Your change clearly is an improvement (the original was grammatically wrong).
But "subscriber nodes may replicate changes without performance degradation
if performing index scans" still feels less than perfect.  Shouldn't it be
"when performing index scans" or "when they perform index scans" or - even
better - "during index scans"?

>     See <xref linkend="logical-replication-security"/> for details on
>     how to configure access control between the subscription and the
> -   publication instance.
> +   publisher instance.

I think you should be consistent: "between the subscriber and the publisher
instance".  But perhaps it would be best to retain the original, because
"publication" and "subscription" are the names of the PostgreSQL objects
involved.  How about "between the database with the subscription and the
database with the publication"?
 
Yours,
Laurenz Albe






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-07 16:03  Thom Brown <thom@linux.com>
  parent: Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 2 replies; 10+ messages in thread

From: Thom Brown @ 2026-10-07 16:03 UTC (permalink / raw)
  To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: pgsql-docs@lists.postgresql.org

On Wed, 7 Oct 2026 at 15:32, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
>
> On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote:
> > I was looking through the new options for create subscription, and
> > found issues with some of the text, so I reviewed the whole page.
> > Attached are my proposed changes.
>
> Thanks!
>
> I agree with most of your changes, but have doubts about a few:
>
> > --- a/doc/src/sgml/ref/create_subscription.sgml
> > +++ b/doc/src/sgml/ref/create_subscription.sgml
>
> >           <para>
> >            Since no connection is made when this option is
> > -          <literal>false</literal>, no tables and sequences are subscribed. To
> > +          <literal>false</literal>, no tables or sequences are subscribed. To
>
> Hm.  I think "and" would be the better conjunction here (although "or"
> is not really wrong).

I think an "or" after a "no" doesn't read well. I think, in order to
use "and", it would have to read "tables and sequences are not
subscribed."

>
> >            send and receive functions will be transferred in binary. Note that
> >            the initial synchronization requires all data types to have binary
> > -          send and receive functions, otherwise the synchronization will fail
> > +          send and receive functions, otherwise synchronization will fail
> >            (see <xref linkend="sql-createtype"/> for more about send/receive
> >            functions). This parameter has no effect for sequences.
>
> My feeling is that the article is correct here (disclaimer: I am not
> a native speaker).

I guess if we're specifically referring to the initial synchronisation
earlier in the sentence, my correction isn't an improvement.

>
> > -           overall system performance. This option provides minimal performance
> > +           overall system performance. This option incurs minimal performance
> >             overhead when applied appropriately. The following scenarios illustrate
>
> I see your point, although you could argue that "minimal performance overhead"
> is a feature, and you provide a feature rather than incur it.
> How about "provides reduced performance overhead"?

I'm not keen on "providing" any overhead, but we could just be
completely neutral about it:

"This option has minimal performance overhead when applied appropriately."

>
> >             c. Read-Only Subscribers:
> >             In configurations involving single or multiple publisher nodes
> >             performing concurrent write operations, read-only subscriber nodes may
> > -           replicate changes without seeing a performance impact if it does index
> > -           scan. However, if the subscriber is impacted due to replication lag or
> > -           scan performance (say due to sequential scans), it needs to follow one
> > +           replicate changes without performance degradation if performing index
> > +           scans. However, if the subscriber is affected due to replication lag or
> > +           scan performance (e.g. due to sequential scans), it needs to follow one
> >             of the two previous strategies to distribute the workload on the
> >             subscriber.
>
> Your change clearly is an improvement (the original was grammatically wrong).
> But "subscriber nodes may replicate changes without performance degradation
> if performing index scans" still feels less than perfect.  Shouldn't it be
> "when performing index scans" or "when they perform index scans" or - even
> better - "during index scans"?

Yeah, fair enough. I would avoid "during index scans" as it makes it
about timing. But "when performing index scans" sounds right.

>
> >     See <xref linkend="logical-replication-security"/> for details on
> >     how to configure access control between the subscription and the
> > -   publication instance.
> > +   publisher instance.
>
> I think you should be consistent: "between the subscriber and the publisher
> instance".  But perhaps it would be best to retain the original, because
> "publication" and "subscription" are the names of the PostgreSQL objects
> involved.  How about "between the database with the subscription and the
> database with the publication"?

Yeah, point taken. Maybe leave that as it is.

Thanks


Thom






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-07 19:08  Laurenz Albe <laurenz.albe@cybertec.at>
  parent: Thom Brown <thom@linux.com>
  1 sibling, 1 reply; 10+ messages in thread

From: Laurenz Albe @ 2026-10-07 19:08 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; +Cc: pgsql-docs@lists.postgresql.org

On Wed, 2026-10-07 at 17:03 +0100, Thom Brown wrote:
> On Wed, 7 Oct 2026 at 15:32, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> > 
> > On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote:
> > > I was looking through the new options for create subscription, and
> > > found issues with some of the text, so I reviewed the whole page.
> > > Attached are my proposed changes.
> > 
> > > --- a/doc/src/sgml/ref/create_subscription.sgml
> > > +++ b/doc/src/sgml/ref/create_subscription.sgml
> > 
> > >           <para>
> > >            Since no connection is made when this option is
> > > -          <literal>false</literal>, no tables and sequences are subscribed. To
> > > +          <literal>false</literal>, no tables or sequences are subscribed. To
> > 
> > Hm.  I think "and" would be the better conjunction here (although "or"
> > is not really wrong).
> 
> I think an "or" after a "no" doesn't read well. I think, in order to
> use "and", it would have to read "tables and sequences are not
> subscribed."

That sounds good to me.

> > >            send and receive functions will be transferred in binary. Note that
> > >            the initial synchronization requires all data types to have binary
> > > -          send and receive functions, otherwise the synchronization will fail
> > > +          send and receive functions, otherwise synchronization will fail
> > >            (see <xref linkend="sql-createtype"/> for more about send/receive
> > >            functions). This parameter has no effect for sequences.
> > 
> > My feeling is that the article is correct here (disclaimer: I am not
> > a native speaker).
> 
> I guess if we're specifically referring to the initial synchronisation
> earlier in the sentence, my correction isn't an improvement.

Good, we are in agreement then.

> > > -           overall system performance. This option provides minimal performance
> > > +           overall system performance. This option incurs minimal performance
> > >             overhead when applied appropriately. The following scenarios illustrate
> > 
> > I see your point, although you could argue that "minimal performance overhead"
> > is a feature, and you provide a feature rather than incur it.
> > How about "provides reduced performance overhead"?
> 
> I'm not keen on "providing" any overhead, but we could just be
> completely neutral about it:
> 
> "This option has minimal performance overhead when applied appropriately."

Well, picking nits, the option itself *is* not a minimal overhead, using it causes
minimal overhead.  So perhaps

  If this option is applied appropriately, the performance overhead will be minimal. 

> > >             c. Read-Only Subscribers:
> > >             In configurations involving single or multiple publisher nodes
> > >             performing concurrent write operations, read-only subscriber nodes may
> > > -           replicate changes without seeing a performance impact if it does index
> > > -           scan. However, if the subscriber is impacted due to replication lag or
> > > -           scan performance (say due to sequential scans), it needs to follow one
> > > +           replicate changes without performance degradation if performing index
> > > +           scans. However, if the subscriber is affected due to replication lag or
> > > +           scan performance (e.g. due to sequential scans), it needs to follow one
> > >             of the two previous strategies to distribute the workload on the
> > >             subscriber.
> > 
> > Your change clearly is an improvement (the original was grammatically wrong).
> > But "subscriber nodes may replicate changes without performance degradation
> > if performing index scans" still feels less than perfect.  Shouldn't it be
> > "when performing index scans" or "when they perform index scans" or - even
> > better - "during index scans"?
> 
> Yeah, fair enough. I would avoid "during index scans" as it makes it
> about timing. But "when performing index scans" sounds right.

Great.

> > >     See <xref linkend="logical-replication-security"/> for details on
> > >     how to configure access control between the subscription and the
> > > -   publication instance.
> > > +   publisher instance.
> > 
> > I think you should be consistent: "between the subscriber and the publisher
> > instance".  But perhaps it would be best to retain the original, because
> > "publication" and "subscription" are the names of the PostgreSQL objects
> > involved.  How about "between the database with the subscription and the
> > database with the publication"?
> 
> Yeah, point taken. Maybe leave that as it is.

Fine!

Yours,
Laurenz Albe






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-07 22:38  Peter Smith <smithpb2250@gmail.com>
  parent: Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 0 replies; 10+ messages in thread

From: Peter Smith @ 2026-10-07 22:38 UTC (permalink / raw)
  To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs@lists.postgresql.org

Hi,

I've read the initial patch and the discussion so far.

FWIW, I think the patch with the changes discussed in this thread
looks good to me.

(I might have worded a couple of them differently, but that's only
personal preference, so I won't muddle your thread with noise)

Let's see an updated patch.

======
Kind Regards,
Peter Smith.
Fujitsu Australia






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-08 06:51  Masahiko Sawada <sawada.mshk@gmail.com>
  parent: Thom Brown <thom@linux.com>
  1 sibling, 0 replies; 10+ messages in thread

From: Masahiko Sawada @ 2026-10-08 06:51 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; +Cc: pgsql-docs@lists.postgresql.org

Hi,

On Wed, Oct 7, 2026 at 3:59 AM Thom Brown <thom@linux.com> wrote:
>
> Hi,
>
> I was looking through the new options for create subscription, and
> found issues with some of the text, so I reviewed the whole page.
> Attached are my proposed changes.
>

Thank you for the patch. The patch overall looks good to me. A one
minor comment:

-          be <literal>pg_conflict_detection</literal> as it is reserved for the
+          be <literal>pg_conflict_detection</literal> as it is reserved for
           conflict detection.

There are other places where we can apply this change. In func-admin.sgml:

       The new slot name cannot be <literal>pg_conflict_detection</literal>,
       as it is reserved for the conflict detection.

and

       <literal>pg_conflict_detection</literal> as it is reserved for
       the conflict detection.  The copied logical slot starts from the same

In protocol.sgml:

          The name cannot be <literal>pg_conflict_detection</literal> as it
          is reserved for the conflict detection.

I think we can backpatch it to v19, where most of the touched text was
added. The remaining changes are wording improvements. What do you
think?

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-18 18:40  Laurenz Albe <laurenz.albe@cybertec.at>
  parent: Thom Brown <thom@linux.com>
  1 sibling, 1 reply; 10+ messages in thread

From: Laurenz Albe @ 2026-10-18 18:40 UTC (permalink / raw)
  To: Thom Brown <thom@linux.com>; +Cc: pgsql-docs@lists.postgresql.org

Attached is a patch with what I hope we can agree on.

On Wed, 2026-10-07 at 17:03 +0100, Thom Brown wrote:
> On Wed, 7 Oct 2026 at 15:32, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> > On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote:
> > >
> > 
> > > --- a/doc/src/sgml/ref/create_subscription.sgml
> > > +++ b/doc/src/sgml/ref/create_subscription.sgml
> > 
> > >           <para>
> > >            Since no connection is made when this option is
> > > -          <literal>false</literal>, no tables and sequences are subscribed. To
> > > +          <literal>false</literal>, no tables or sequences are subscribed. To
> > 
> > Hm.  I think "and" would be the better conjunction here (although "or"
> > is not really wrong).
> 
> I think an "or" after a "no" doesn't read well. I think, in order to
> use "and", it would have to read "tables and sequences are not
> subscribed."

I went with "tables and sequences are not yet subscribed".

> > 
> > > -           overall system performance. This option provides minimal performance
> > > +           overall system performance. This option incurs minimal performance
> > >             overhead when applied appropriately. The following scenarios illustrate
> > 
> > I see your point, although you could argue that "minimal performance overhead"
> > is a feature, and you provide a feature rather than incur it.
> > How about "provides reduced performance overhead"?
> 
> I'm not keen on "providing" any overhead, but we could just be
> completely neutral about it:
> 
> "This option has minimal performance overhead when applied appropriately."

I read the paragraph again, and I think that your original "incurs"
is actually better.  After all, "retain_dead_tuples" incurs an overhead.
It's just that that overhead can be small if you do it right.

> > >             c. Read-Only Subscribers:
> > >             In configurations involving single or multiple publisher nodes
> > >             performing concurrent write operations, read-only subscriber nodes may
> > > -           replicate changes without seeing a performance impact if it does index
> > > -           scan. However, if the subscriber is impacted due to replication lag or
> > > -           scan performance (say due to sequential scans), it needs to follow one
> > > +           replicate changes without performance degradation if performing index
> > > +           scans. However, if the subscriber is affected due to replication lag or
> > > +           scan performance (e.g. due to sequential scans), it needs to follow one
> > >             of the two previous strategies to distribute the workload on the
> > >             subscriber.
> > 
> > Your change clearly is an improvement (the original was grammatically wrong).
> > But "subscriber nodes may replicate changes without performance degradation
> > if performing index scans" still feels less than perfect.  Shouldn't it be
> > "when performing index scans" or "when they perform index scans" or - even
> > better - "during index scans"?
> 
> Yeah, fair enough. I would avoid "during index scans" as it makes it
> about timing. But "when performing index scans" sounds right.

Done that way.

> > >     See <xref linkend="logical-replication-security"/> for details on
> > >     how to configure access control between the subscription and the
> > > -   publication instance.
> > > +   publisher instance.
> > 
> > I think you should be consistent: "between the subscriber and the publisher
> > instance".  But perhaps it would be best to retain the original, because
> > "publication" and "subscription" are the names of the PostgreSQL objects
> > involved.  How about "between the database with the subscription and the
> > database with the publication"?
> 
> Yeah, point taken. Maybe leave that as it is.

Done.

I have also removed the two "the" from the system administration function
documentation, as Masahiko suggested.

Masahiko, do you want to commit that before v19 goes live, or should we
add it to the next commitfest?

Yours,
Laurenz Albe

Attachments:

v2-0001-Small-fixes-for-the-CREATE-SUBSCRIPTION-documenta.patch (text/x-patch, 6.7K) download From 2d60772c92b120a5f24c0967ff117ab50061c1e5 Mon Sep 17 00:00:00 2001 From: Laurenz Albe <laurenz.albe@cybertec.at> Date: Sun, 18 Oct 2026 20:31:32 +0200 Subject: [PATCH v2] Small fixes for the CREATE SUBSCRIPTION documentation The documentation added by commits 55cefadde8, 228c370868, a850be2fe6 and 8756930190 had grammatical and stylistic shortcomings. In passing, remove two articles from the system administration functions documentation. Author: Thom Brown <thom@linux.com> Reviewed-By: Laurenz Albe <laurenz.albe@cybertec.at> Reviewed-By: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/CAA-aLv4tAU6yY=OUa7Fisy+Kk_4bS-mJreQUJjU-HhJOA9TB-w@mail.gmail.com --- doc/src/sgml/func/func-admin.sgml | 4 ++-- doc/src/sgml/ref/create_subscription.sgml | 25 ++++++++++++----------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/doc/src/sgml/func/func-admin.sgml b/doc/src/sgml/func/func-admin.sgml index 64b0e7bb972..800c1564e7b 100644 --- a/doc/src/sgml/func/func-admin.sgml +++ b/doc/src/sgml/func/func-admin.sgml @@ -1118,7 +1118,7 @@ postgres=# SELECT '0/0'::pg_lsn + pd.segment_number * ps.setting::int + :offset Copies an existing physical replication slot named <parameter>src_slot_name</parameter> to a physical replication slot named <parameter>dst_slot_name</parameter>. The new slot name cannot be <literal>pg_conflict_detection</literal>, - as it is reserved for the conflict detection. + as it is reserved for conflict detection. The copied physical slot starts to reserve WAL from the same <acronym>LSN</acronym> as the source slot. <parameter>temporary</parameter> is optional. If <parameter>temporary</parameter> @@ -1143,7 +1143,7 @@ postgres=# SELECT '0/0'::pg_lsn + pd.segment_number * ps.setting::int + :offset slot named <parameter>dst_slot_name</parameter>, optionally changing the output plugin and persistence. The new slot name cannot be <literal>pg_conflict_detection</literal> as it is reserved for - the conflict detection. The copied logical slot starts from the same + conflict detection. The copied logical slot starts from the same <acronym>LSN</acronym> as the source logical slot. Both <parameter>temporary</parameter> and <parameter>plugin</parameter> are optional; if they are omitted, the values of the source slot are used. diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 6248c228a64..0d27d03603b 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -141,9 +141,9 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> Since no connection is made when this option is - <literal>false</literal>, no tables and sequences are subscribed. To - initiate replication, you must manually create the replication slot, - enable the failover if required, enable the subscription, and refresh + <literal>false</literal>, tables and sequences are not yet subscribed. + To initiate replication, you must manually create the replication slot, + enable failover if required, enable the subscription, and refresh the subscription. See <xref linkend="logical-replication-subscription-examples-deferred-slot"/> for examples. @@ -184,7 +184,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> Name of the publisher's replication slot to use. The default is to use the name of the subscription for the slot name. The name cannot - be <literal>pg_conflict_detection</literal> as it is reserved for the + be <literal>pg_conflict_detection</literal> as it is reserved for conflict detection. </para> @@ -555,7 +555,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl Additionally when enabling <literal>retain_dead_tuples</literal> for conflict detection in logical replication, it is important to design the replication topology to balance data retention requirements with - overall system performance. This option provides minimal performance + overall system performance. This option incurs minimal performance overhead when applied appropriately. The following scenarios illustrate effective usage patterns when enabling this option. </para> @@ -581,9 +581,9 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl c. Read-Only Subscribers: In configurations involving single or multiple publisher nodes performing concurrent write operations, read-only subscriber nodes may - replicate changes without seeing a performance impact if it does index - scan. However, if the subscriber is impacted due to replication lag or - scan performance (say due to sequential scans), it needs to follow one + replicate changes without performance degradation when performing index + scans. However, if the subscriber is affected due to replication lag or + scan performance (e.g. due to sequential scans), it needs to follow one of the two previous strategies to distribute the workload on the subscriber. </para> @@ -636,9 +636,10 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl can be manually resumed by re-enabling <literal>retain_dead_tuples</literal>. </para> <para> - Note that overall retention will not stop if other subscriptions that - have a value greater than 0 for this parameter have not exceeded it, - or if they set this option to 0. + Note that overall retention will not stop while any other subscription + with <literal>retain_dead_tuples</literal> enabled either has this + option set to <literal>0</literal> or has not yet exceeded its nonzero + limit. </para> <para> This option is effective only when @@ -769,7 +770,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl originated from further upstream. This scenario is detected and a WARNING is logged to the user, but the warning is only an indication of a potential problem; it is the user's responsibility to make the necessary checks to - ensure the copied data origins are really as wanted or not. + ensure the origins of the copied data are as intended. </para> <para> -- 2.56.0
^ permalink raw reply [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-18 22:22  Peter Smith <smithpb2250@gmail.com>
  parent: Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 1 reply; 10+ messages in thread

From: Peter Smith @ 2026-10-18 22:22 UTC (permalink / raw)
  To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs@lists.postgresql.org

FWIW, it LGTM.

======
Kind Regards,
Peter Smith.
Futjisu Australia






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-19 12:08  Matemática A3K <matematica.a3k@gmail.com>
  parent: Peter Smith <smithpb2250@gmail.com>
  0 siblings, 1 reply; 10+ messages in thread

From: Matemática A3K @ 2026-10-19 12:08 UTC (permalink / raw)
  To: Peter Smith <smithpb2250@gmail.com>; +Cc: Laurenz Albe <laurenz.albe@cybertec.at>; Thom Brown <thom@linux.com>; pgsql-docs@lists.postgresql.org

On Sun, Oct 18, 2026 at 7:23 PM Peter Smith <smithpb2250@gmail.com> wrote:

> FWIW, it LGTM.
>
+1

^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Fixes for create subscription page
@ 2026-10-23 04:37  Laurenz Albe <laurenz.albe@cybertec.at>
  parent: Matemática A3K <matematica.a3k@gmail.com>
  0 siblings, 0 replies; 10+ messages in thread

From: Laurenz Albe @ 2026-10-23 04:37 UTC (permalink / raw)
  To: Matemática A3K <matematica.a3k@gmail.com>; Peter Smith <smithpb2250@gmail.com>; +Cc: Thom Brown <thom@linux.com>; pgsql-docs@lists.postgresql.org

On Mon, 2026-10-19 at 09:08 -0300, Matemática A3K wrote:
> On Sun, Oct 18, 2026 at 7:23 PM Peter Smith <smithpb2250@gmail.com> wrote:
> > FWIW, it LGTM.
> > 
> 
> +1 

I have added a commitfest entry (https://commitfest.postgresql.org/patch/7505/)
so that this doesn't get lost.

Yours,
Laurenz Albe






^ permalink  raw  reply  [nested|flat] 10+ messages in thread


end of thread, other threads:[~2026-10-23 04:37 UTC | newest]

Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-10-07 10:58 Fixes for create subscription page Thom Brown <thom@linux.com>
2026-10-07 14:32 ` Laurenz Albe <laurenz.albe@cybertec.at>
2026-10-07 16:03   ` Thom Brown <thom@linux.com>
2026-10-07 19:08     ` Laurenz Albe <laurenz.albe@cybertec.at>
2026-10-07 22:38       ` Peter Smith <smithpb2250@gmail.com>
2026-10-18 18:40     ` Laurenz Albe <laurenz.albe@cybertec.at>
2026-10-18 22:22       ` Peter Smith <smithpb2250@gmail.com>
2026-10-19 12:08         ` Matemática A3K <matematica.a3k@gmail.com>
2026-10-23 04:37           ` Laurenz Albe <laurenz.albe@cybertec.at>
2026-10-08 06:51 ` Masahiko Sawada <sawada.mshk@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox