agora inbox for pgsql-docs@postgresql.org  

help / color / mirror / Atom feed

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Robert Treat <rob@xzilla.net>
To: euler@eulerto.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Remove unnecessary secondary index terms for replication settings
Date: Fri, 25 Apr 2025 15:02:09 +0900
Message-ID: <e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com> (raw)
In-Reply-To: <CABV9wwOaN5EDtkUSaOib=C7kf2TQd9aJJBy0DeCoaDBFS49JoQ@mail.gmail.com>
References: <e825e7a7-4877-441d-93c1-25377db36c31@oss.nttdata.com>
	<CABV9wwOaN5EDtkUSaOib=C7kf2TQd9aJJBy0DeCoaDBFS49JoQ@mail.gmail.com>



On 2025/04/24 23:30, Robert Treat wrote:
> On Wed, Apr 23, 2025 at 2:54 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> Hi,
>>
>> In config.sgml, the entries for max_replication_slots and
>> max_active_replication_origins include secondary index terms:
>>
>>           <primary><varname>max_replication_slots</varname> configuration parameter</primary>
>>           <secondary>in a sending server</secondary>
>>
>>           <primary><varname>max_active_replication_origins</varname> configuration parameter</primary>
>>           <secondary>in a subscriber</secondary>
>>
>> These secondary terms don't seem necessary anymore, since each parameter
>> now has only one index entry. Removing them would simplify the documentation.
>>
>> Originally, the secondary entries made sense because
>> max_active_replication_origins was part of max_replication_slots,
>> so both needed separate index entries. But commit 04ff636cbce
>> split them into distinct parameters.
>>
>> Patch attached.
>>
> 
> Make sense, +1 from me.

Thanks both for the review! I've pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

view thread (4+ messages)

Message-ID: <e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com>
Permalink:  ../e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com/
Also on:    postgresql.org/message-id/e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, rob@xzilla.net, euler@eulerto.com, pgsql-docs@lists.postgresql.org
  Subject: Re: Remove unnecessary secondary index terms for replication settings
  In-Reply-To: <e62e9e3a-4ec4-4297-a39c-3ca2ad72789b@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox