agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedClarify old WAL files cannot be removed until they are summarized
5+ messages / 2 participants
[nested] [flat]
* Clarify old WAL files cannot be removed until they are summarized
@ 2024-10-17 17:25 Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Fujii Masao @ 2024-10-17 17:25 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hi,
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not
mention that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. Attached patch adds that clarification to
the documentation. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From 1339bbb4096df0182913c19a6277a105a2f5bee8 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Fri, 18 Oct 2024 02:20:49 +0900
Subject: [PATCH v1] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
---
doc/src/sgml/wal.sgml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..5588f31c55 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,8 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if WAL summarization is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.46.2
Attachments:
[text/plain] v1-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch (1.1K, ../../fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com/2-v1-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch)
download | inline diff:
From 1339bbb4096df0182913c19a6277a105a2f5bee8 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Fri, 18 Oct 2024 02:20:49 +0900
Subject: [PATCH v1] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
---
doc/src/sgml/wal.sgml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..5588f31c55 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,8 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if WAL summarization is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.46.2
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Clarify old WAL files cannot be removed until they are summarized
@ 2024-12-11 00:18 Michael Paquier <michael@paquier.xyz>
parent: Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Michael Paquier @ 2024-12-11 00:18 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: pgsql-docs@lists.postgresql.org
On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:
> The documentation in wal.sgml explains that old WAL files cannot be
> removed or recycled until they are archived (when WAL archiving is used)
> or replicated (when using replication slots). However, it did not
> mention that, similarly, old WAL files are also kept until they are summarized
> if WAL summarization is enabled. Attached patch adds that clarification to
> the documentation. Thought?
>
> @@ -643,6 +643,8 @@
> until the situation is resolved. A slow or failed standby server that
> uses a replication slot will have the same effect (see
> <xref linkend="streaming-replication-slots"/>).
> + Similarly, if WAL summarization is enabled, old segments are kept
> + until they are summarized.
> </para>
Sounds like a good idea to me. I'd suggest to add a link to
runtime-config-wal-summarization as it is the first reference to WAL
summarization in this file.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Z1jaaLi2vq-Wpk9y@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Clarify old WAL files cannot be removed until they are summarized
@ 2024-12-12 15:08 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 5+ messages in thread
From: Fujii Masao @ 2024-12-12 15:08 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs@lists.postgresql.org
On 2024/12/11 9:18, Michael Paquier wrote:
> On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:
>> The documentation in wal.sgml explains that old WAL files cannot be
>> removed or recycled until they are archived (when WAL archiving is used)
>> or replicated (when using replication slots). However, it did not
>> mention that, similarly, old WAL files are also kept until they are summarized
>> if WAL summarization is enabled. Attached patch adds that clarification to
>> the documentation. Thought?
>>
>> @@ -643,6 +643,8 @@
>> until the situation is resolved. A slow or failed standby server that
>> uses a replication slot will have the same effect (see
>> <xref linkend="streaming-replication-slots"/>).
>> + Similarly, if WAL summarization is enabled, old segments are kept
>> + until they are summarized.
>> </para>
>
> Sounds like a good idea to me. I'd suggest to add a link to
> runtime-config-wal-summarization as it is the first reference to WAL
> summarization in this file.
Yes, that sounds like a good idea. I've updated the patch accordingly.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From b0d6ceb6799889e3d9269948342a249c67c71341 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Thu, 12 Dec 2024 23:46:23 +0900
Subject: [PATCH v2] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
Back-patch to v17 where WAL summarization was added.
Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com
---
doc/src/sgml/wal.sgml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..b908720ade 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,9 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if <link linkend="runtime-config-wal-summarization">
+ WAL summarization</link> is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.47.0
Attachments:
[text/plain] v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch (1.4K, ../../87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com/2-v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch)
download | inline diff:
From b0d6ceb6799889e3d9269948342a249c67c71341 Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Thu, 12 Dec 2024 23:46:23 +0900
Subject: [PATCH v2] doc: Clarify old WAL files are kept until they are
summarized.
The documentation in wal.sgml explains that old WAL files cannot be
removed or recycled until they are archived (when WAL archiving is used)
or replicated (when using replication slots). However, it did not mention
that, similarly, old WAL files are also kept until they are summarized
if WAL summarization is enabled. This commit adds that clarification
to the documentation.
Back-patch to v17 where WAL summarization was added.
Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com
---
doc/src/sgml/wal.sgml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index a34cddb5ed..b908720ade 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -643,6 +643,9 @@
until the situation is resolved. A slow or failed standby server that
uses a replication slot will have the same effect (see
<xref linkend="streaming-replication-slots"/>).
+ Similarly, if <link linkend="runtime-config-wal-summarization">
+ WAL summarization</link> is enabled, old segments are kept
+ until they are summarized.
</para>
<para>
--
2.47.0
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Clarify old WAL files cannot be removed until they are summarized
@ 2024-12-13 00:12 Michael Paquier <michael@paquier.xyz>
parent: Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 5+ messages in thread
From: Michael Paquier @ 2024-12-13 00:12 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: pgsql-docs@lists.postgresql.org
On Fri, Dec 13, 2024 at 12:08:06AM +0900, Fujii Masao wrote:
> Yes, that sounds like a good idea. I've updated the patch accordingly.
LGTM.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Z1t73LZbGngJ1Vj3@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Clarify old WAL files cannot be removed until they are summarized
@ 2024-12-15 02:22 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2024-12-15 02:22 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs@lists.postgresql.org
On 2024/12/13 9:12, Michael Paquier wrote:
> On Fri, Dec 13, 2024 at 12:08:06AM +0900, Fujii Masao wrote:
>> Yes, that sounds like a good idea. I've updated the patch accordingly.
>
> LGTM.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-12-15 02:22 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-10-17 17:25 Clarify old WAL files cannot be removed until they are summarized Fujii Masao <masao.fujii@oss.nttdata.com>
2024-12-11 00:18 ` Michael Paquier <michael@paquier.xyz>
2024-12-12 15:08 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2024-12-13 00:12 ` Michael Paquier <michael@paquier.xyz>
2024-12-15 02:22 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox