pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Bartosz Chroł <bartosz.chrol@handen.pl>
Cc: pgsql-general@postgresql.org <pgsql-general@postgresql.org>
Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well
Date: Thu, 21 Mar 2024 13:28:56 +0100
Message-ID: <202403211228.4szqmhopsskk@alvherre.pgsql> (raw)
In-Reply-To: <86FC9F16-E6AA-4C04-B0FB-024662CA8D2A@yesql.se>

On 2024-Mar-21, Daniel Gustafsson wrote:

> Comments on roles are stored against the pg_authid catalog relation which is
> the catalog used for dumping roles, but when using --no-role-passwords we
> instead switch to using the pg_roles catalog relation.  Since comments are
> dumped for the relations which are dumped, this means that the comments on
> roles are omitted when --no-role-passwords is used.
> 
> It's not clear whether that was intentional or not, I'm failing to find the
> thread where it was discussed on a quick mailing list search.

Here it is:
https://www.postgresql.org/message-id/flat/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%4...

I very much doubt that they realized that comments were going to be
omitted.  But clearly it's just a mistake, and easily fixed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"After a quick R of TFM, all I can say is HOLY CR** THAT IS COOL! PostgreSQL was
amazing when I first started using it at 7.2, and I'm continually astounded by
learning new features and techniques made available by the continuing work of
the development team."
Berend Tober, http://archives.postgresql.org/pgsql-hackers/2007-08/msg01009.php

Attachments:

  v1-0001-fix-dump-of-role-comments-with-no-role-passwords.patch (text/x-diff, 0B) download

view thread (8+ messages)  latest in thread

Message-ID: <202403211228.4szqmhopsskk@alvherre.pgsql>
Permalink:  ../202403211228.4szqmhopsskk@alvherre.pgsql/
Also on:    postgresql.org/message-id/202403211228.4szqmhopsskk@alvherre.pgsql

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: alvherre@alvh.no-ip.org, daniel@yesql.se, bartosz.chrol@handen.pl
  Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well
  In-Reply-To: <202403211228.4szqmhopsskk@alvherre.pgsql>
  References: <86FC9F16-E6AA-4C04-B0FB-024662CA8D2A@yesql.se> <202403211228.4szqmhopsskk@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox