pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Bartosz Chroł <bartosz.chrol@handen.pl>
Cc: pgsql-general@postgresql.org <pgsql-general@postgresql.org>
Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well
Date: Thu, 21 Mar 2024 14:27:30 +0100
Message-ID: <202403211327.3mwhawgoeqp3@alvherre.pgsql> (raw)
In-Reply-To: <33D59EC6-C78F-410D-964B-80449B76EA96@yesql.se>

On 2024-Mar-21, Daniel Gustafsson wrote:

> On 21 Mar 2024, at 13:28, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> > I very much doubt that they realized that comments were going to be
> > omitted.  But clearly it's just a mistake, and easily fixed.
> 
> It sure looks like a search/replace kind of bug.  I had just typed up the exact
> same patch with the addition of a comment on why pg_authid is used and was
> about to hit send when your email came =) Are you committing it or do you want
> me to take care of it?

Hah :-)  Please do.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Here's a general engineering tip: if the non-fun part is too complex for you
to figure out, that might indicate the fun part is too ambitious." (John Naylor)
https://postgr.es/m/CAFBsxsG4OWHBbSDM%3DsSeXrQGOtkPiOEOuME4yD7Ce41NtaAD9g%40mail.gmail.com





view thread (8+ messages)  latest in thread

Message-ID: <202403211327.3mwhawgoeqp3@alvherre.pgsql>
Permalink:  ../202403211327.3mwhawgoeqp3@alvherre.pgsql/
Also on:    postgresql.org/message-id/202403211327.3mwhawgoeqp3@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: alvherre@alvh.no-ip.org, daniel@yesql.se, bartosz.chrol@handen.pl
  Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well
  In-Reply-To: <202403211327.3mwhawgoeqp3@alvherre.pgsql>
  References: <33D59EC6-C78F-410D-964B-80449B76EA96@yesql.se> <202403211327.3mwhawgoeqp3@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox