public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Bernice Southey <[email protected]>
Cc: [email protected]
Subject: Re: Indentation in a patch
Date: Tue, 25 Nov 2025 19:58:25 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEDh4nxfE_dte840rgD-YM8M57qijYGv-R75MLgPRx-+=pS6hQ@mail.gmail.com>
References: <CAEDh4nxfE_dte840rgD-YM8M57qijYGv-R75MLgPRx-+=pS6hQ@mail.gmail.com>

> On 25 Nov 2025, at 19:14, Bernice Southey <[email protected]> wrote:

> .. for my first ever patch attempt.

Awesome, we love to see new contributors!

> I'm tempted to submit my patch without indenting the
> if-block, and an explanation.

That's perfectly fine, an incorrectly indentend diff is fine to submit if it
makes it more readable (especially when coupled with a note explaining why).

> While I'm asking, I added a regression test and ran make check-world
> with the TAP tests. Anything else I should do before sending it to
> hackers?

Sounds like you've completed all the required steps.

--
Daniel Gustafsson

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Indentation in a patch
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox